feat (modularize): First steps to modularizing Pan3D components#194

Merged

ayenpure merged 4 commits intoKitware:mainfrom

ayenpure:modularize_pan3d

Jun 18, 2025

Contributor

ayenpure commented May 23, 2025

Addressing issue #186

-- modulerized Pan3D color picker and scalar bar

ayenpure requested a review from jourdain

May 23, 2025 22:06

ayenpure marked this pull request as draft

May 24, 2025 01:01

jourdain reviewed

View reviewed changes

src/pan3d/explorers/analytics.py Outdated

Collaborator

jourdain commented May 25, 2025

I don't see much isolation from what you are doing... You are still in the Widget mode more than the Component mode.

jourdain reviewed

View reviewed changes

src/pan3d/explorers/globe.py Outdated

src/pan3d/explorers/slicer.py Outdated

src/pan3d/viewers/preview.py Outdated

src/pan3d/widgets/color.py Outdated

src/pan3d/widgets/color.py Outdated

Collaborator

jourdain commented May 25, 2025

You need to think about responsibilities and try to isolate yourself the best you can so you can create more usage benefits.


          feat (modularize): First steps to modularizing Pan3D components

4e64c14

  Addressing issue Kitware#186

  -- modulerized Pan3D color picker and scalar bar

ayenpure force-pushed the modularize_pan3d branch from 61e3100 to 4e64c14 Compare

May 28, 2025 17:28

jourdain reviewed

View reviewed changes

src/pan3d/explorers/contour.py

jourdain reviewed

View reviewed changes

src/pan3d/ui/contour.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/widgets/color.py Outdated

aashish24 mentioned this pull request

Exposed pan3d components as trame widgets and ui #189

Closed

ayenpure added 2 commits

June 3, 2025 16:09


          feat (modularize): Adding scalar bar component

1145c6d


          fix (scalar bar): Fixing scalar bar abstraction

1082e33

ayenpure force-pushed the modularize_pan3d branch from e8a6562 to ba302ae Compare

June 6, 2025 21:11

jourdain reviewed

View reviewed changes

src/pan3d/explorers/analytics.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/analytics.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/analytics.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/analytics.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/analytics.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/analytics.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/contour.py

jourdain reviewed

View reviewed changes

src/pan3d/explorers/contour.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/contour.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/contour.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/contour.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/globe.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/globe.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/globe.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/explorers/slicer.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/viewers/preview.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/widgets/color_by.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/widgets/color_by.py Outdated

ayenpure force-pushed the modularize_pan3d branch 4 times, most recently from 5908345 to 3790354 Compare

June 17, 2025 17:20

ayenpure self-assigned this

ayenpure marked this pull request as ready for review

June 17, 2025 17:22

ayenpure force-pushed the modularize_pan3d branch 2 times, most recently from 3dba1eb to ad14cf5 Compare

June 17, 2025 19:32

jourdain reviewed

View reviewed changes

src/pan3d/explorers/contour.py

jourdain reviewed

View reviewed changes

src/pan3d/ui/globe.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/ui/globe.py

jourdain reviewed

View reviewed changes

src/pan3d/utils/common.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/utils/common.py

jourdain reviewed

View reviewed changes

src/pan3d/widgets/color_by.py

jourdain reviewed

View reviewed changes

src/pan3d/widgets/color_by.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/widgets/color_by.py

jourdain self-requested a review

June 18, 2025 14:32

Collaborator

jourdain commented Jun 18, 2025

It seems that you may have to update the CI to use a newer version of Python.

ayenpure force-pushed the modularize_pan3d branch 3 times, most recently from 5c1ac69 to 8fdcafa Compare

June 18, 2025 21:59

jourdain reviewed

View reviewed changes

src/pan3d/explorers/analytics.py Outdated

jourdain reviewed

View reviewed changes

src/pan3d/widgets/color_by.py Outdated


          fix (modularize): Redo color_by component

617ca33

ayenpure force-pushed the modularize_pan3d branch from 8fdcafa to 617ca33 Compare

June 18, 2025 22:46

jourdain approved these changes

View reviewed changes

ayenpure merged commit 29981a1 into Kitware:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet