Skip to content

fix(append pipeline): Adding additional filter/custom code to pipeline#196

Merged
ayenpure merged 1 commit intoKitware:mainfrom
ayenpure:flotran_custom_code
Jun 25, 2025
Merged

fix(append pipeline): Adding additional filter/custom code to pipeline#196
ayenpure merged 1 commit intoKitware:mainfrom
ayenpure:flotran_custom_code

Conversation

@ayenpure
Copy link
Copy Markdown
Contributor

This PR addresses the feature request from
#191

@ayenpure ayenpure requested a review from jourdain June 19, 2025 22:46
@ayenpure
Copy link
Copy Markdown
Contributor Author

@jourdain This is meant to be just the initial check-in to demonstrate what we chatted about.
The Jupyter Lab example works, but I wanted to verify that this is what we had in mind.
If this feels alright, I can make changes to other explorers and add the method add_to_pipeline to the constructor.

@jourdain
Copy link
Copy Markdown
Collaborator

Yes that is what I had in mind. Spiros told be that it is better to use vtkGeometryFilter instead of vtkDataSetSurfaceFilter.
It is faster when using stdthread for vtkSMP.

@ayenpure ayenpure force-pushed the flotran_custom_code branch from 0ffaaa0 to 30a10b6 Compare June 23, 2025 20:25
@ayenpure
Copy link
Copy Markdown
Contributor Author

@johnkit The Jupyter Lab example I added with this PR has an example of extending the pipeline.
It addresses your use case -- let me know what you think.

@ayenpure
Copy link
Copy Markdown
Contributor Author

@jourdain ready for review

@ayenpure ayenpure self-assigned this Jun 23, 2025
@jourdain
Copy link
Copy Markdown
Collaborator

Need to skip examples/jupyter/pflotran_extend_pipeline.ipynb:35: fo ==> of, for, to, do, go for the CI

@jourdain
Copy link
Copy Markdown
Collaborator

@jourdain
Copy link
Copy Markdown
Collaborator

You just need to fix the CI now.

@ayenpure ayenpure force-pushed the flotran_custom_code branch 3 times, most recently from a115877 to a45d2eb Compare June 25, 2025 18:39
@ayenpure ayenpure force-pushed the flotran_custom_code branch from a45d2eb to 32472fb Compare June 25, 2025 20:58
@ayenpure ayenpure merged commit 0ea7321 into Kitware:main Jun 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants