Guard volume mapper when shader program is unavailable#3490
Open
nutzlastfan wants to merge 1 commit intoKitware:masterfrom
Open
Guard volume mapper when shader program is unavailable#3490nutzlastfan wants to merge 1 commit intoKitware:masterfrom
nutzlastfan wants to merge 1 commit intoKitware:masterfrom
Conversation
finetjul
requested changes
Apr 30, 2026
Member
finetjul
left a comment
There was a problem hiding this comment.
LGTM but please reword your commit title to follow semantic-release pattern. you can use Commitizen to create your commit. See CONTRIBUTING.md
3e23100 to
f598d30
Compare
Author
|
Thanks, updated the commit title to follow the semantic-release pattern: fix(VolumeMapper): guard unavailable shader program Force-pushed the amended single commit branch at f598d30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
ShaderCache.readyShaderProgramArray(...) and readyShaderProgram(...) can return null when shader compilation or binding fails.
VolumeMapper currently continues into setMapperShaderParameters, where program.isAttributeUsed(...) can throw because cellBO.getProgram() is null.
This keeps the original shader compile failure as the root error while preventing the follow-up null dereference and avoiding a draw with an invalid shader program.
Test
node --input-type=module --check
I did not run the full vtk-js test suite locally.