Skip to content

fix(InteractorStyleTrackballCamera): stop mouse move amplifying wheel zoom #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finetjul merged 1 commit into from
May 7, 2026
+9 −2
Merged

fix(InteractorStyleTrackballCamera): stop mouse move amplifying wheel zoom #3499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Sources/Interaction/Style/InteractorStyleTrackballCamera/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@ function vtkInteractorStyleTrackballCamera(publicAPI, model) {
break;

case States.IS_DOLLY:
publicAPI.handleMouseDolly(renderer, pos);
publicAPI.invokeInteractionEvent({ type: 'InteractionEvent' });
// Wheel zoom uses the dolly state too, we should ignore pointer movement
// so the mouse position does not amplify wheel zoom while scrolling.
if (!model.wheelDolly) {
publicAPI.handleMouseDolly(renderer, pos);
publicAPI.invokeInteractionEvent({ type: 'InteractionEvent' });
}
break;

case States.IS_SPIN:
Expand Down Expand Up @@ -154,12 +158,14 @@ function vtkInteractorStyleTrackballCamera(publicAPI, model) {

//----------------------------------------------------------------------------
publicAPI.handleStartMouseWheel = () => {
model.wheelDolly = true;
publicAPI.startDolly();
};

//--------------------------------------------------------------------------
publicAPI.handleEndMouseWheel = () => {
publicAPI.endDolly();
model.wheelDolly = false;
};

//----------------------------------------------------------------------------
Expand Down Expand Up @@ -448,6 +454,7 @@ function vtkInteractorStyleTrackballCamera(publicAPI, model) {
const DEFAULT_VALUES = {
motionFactor: 10.0,
zoomFactor: 10.0,
wheelDolly: false,
};

// ----------------------------------------------------------------------------
Expand Down
Loading