Skip to content

Bloomknights#456

Merged
DVidal1205 merged 10 commits into
mainfrom
bloomknights
May 31, 2026
Merged

Bloomknights#456
DVidal1205 merged 10 commits into
mainfrom
bloomknights

Conversation

@Adr1an04
Copy link
Copy Markdown
Contributor

@Adr1an04 Adr1an04 commented May 31, 2026

Closes #455

Why

BloomKnights is currently its own branch of visual/site work, and this PR packages that work so it can land before the hackathon form frontend branch that builds on top of it.

What

  • added the BloomKnights site and related assets
  • added animated/optimized background graphics for the BloomKnights pages
  • added floating flower/icon details and page animation polish
  • added CDN/R2 cached asset support for BloomKnights
  • applied AVIF/WebP optimization work for background and tablet assets
  • fixed formatting issues so CI format passes

Test Plan

  • ran pnpm format
  • ran pnpm lint
  • ran pnpm typecheck
  • ran pnpm lint:ws

What you should test

  • Make sure it works cleanly on all devices etc
  • All images load

Warning

The hackathon itself has not been made, so the link on https://blade.knighthacks.org/hacker/application/bloomknights does not work. in the next pr we will make the hackathon on prod and test the system for applying.

Video

Screen.Recording.2026-05-31.at.10.28.21.AM.1.mp4

Summary by CodeRabbit

  • New Features

    • Launched BloomKnights web application with FAQ, partner showcase, footer, and animated hero section featuring decorative graphics, floating elements, and scroll-triggered animations.
    • Added navbar with navigation links and Discord badge integration.
    • Enhanced form response display with "No response" messaging for missing data.
  • Style

    • Standardized UI labels across admin forms by replacing em-dashes with commas.
    • Implemented comprehensive styling for BloomKnights with animations and responsive design.
  • Chores

    • Added configuration files for BloomKnights app (Tailwind, TypeScript, Next.js, ESLint, PostCSS).
    • Minor code formatting adjustments.

@Adr1an04 Adr1an04 requested a review from a team as a code owner May 31, 2026 16:35
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR adds the BloomKnights event website as a new Next.js app within the Forge monorepo, complete with animated graphics, interactive sections, and global styling. Concurrently, UI text is standardized across Blade and 2025 apps by replacing em-dashes with commas and normalizing missing-value placeholders to "No response."

Changes

BloomKnights Event Website

Layer / File(s) Summary
Next.js and tooling configuration
apps/bloomknights/{components.json, eslint.config.js, next.config.js, package.json, postcss.config.cjs, tsconfig.json, turbo.json}
Project scaffolding with Next.js strict mode, image optimization (AVIF/WebP, 30-day cache), TypeScript/ESLint/TurboRepo setup, Shadcn UI config, and PostCSS/Tailwind integration.
Animated graphics and visual primitives
apps/bloomknights/src/app/_components/graphics/*
Reusable animated components: bird flocks (sky/about/FAQ contexts), floating petals, mouse-trail flower cursor with motion detection, dynamically assembled logo with CSS variable transforms, and static partner SVG graphics (Gemini, GitHub, MLH, OneEthos).
Navigation, footer, and layout wrappers
apps/bloomknights/src/app/_components/navbar/*, footer/*
Navbar with scroll-position glow control and floating MLH badge, footer with conditional link rendering (mailto vs external), and shared content exports for link/message constants.
About, FAQ, Partners, and Register sections
apps/bloomknights/src/app/_components/{about, faq, partners, register}/*
Full-page sections with Framer Motion reveal animations, Radix Accordion FAQ, partner card hover-reveal with dual logo marks, Discord call-to-action with GSAP scroll trigger, and register button with conic-gradient animation. Includes structured FAQ data module.
Root layout, home page, and SEO metadata
apps/bloomknights/src/app/{layout.tsx, page.tsx, robots.ts, sitemap.ts, opengraph-image.tsx, seo.ts}
Root layout composing navbar, hero, content sections, JSON-LD event schema, and footer. Home page features scroll-driven hero with Framer Motion spring transforms. SEO routes handle robots directives, sitemap generation, OG image creation, and event metadata constants.
Global styles and Tailwind configuration
apps/bloomknights/src/app/globals.css, tailwind.config.ts
2200+ lines of CSS including Tailwind directives, design tokens (colors, radii, animations), keyframe animations (bird motion, bloom reveals, FAQ interactions, partner leaf drift), responsive theming, and prefers-reduced-motion handling. Tailwind config extends colors, typography, custom animations, and shadow utilities.

Blade and 2025 Apps: UI Text Updates

Layer / File(s) Summary
Punctuation and placeholder standardization
apps/blade/src/app/_components/**/*.tsx, apps/blade/src/app/admin/**/*.tsx, apps/2025/src/app/_components/faq/faq.tsx
Standardized em-dash () to comma in 30+ locations: form field "Optional" labels, comment markers, judge/donation display labels, and CSS comments. Missing-value placeholders changed from em-dash to "No response" in form response tables, rating badges, and devpost fallbacks.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes


Suggested labels

Hack Sites, Blade, Major, Feature


Suggested reviewers

  • alexanderpaolini
  • DVidal1205
🚥 Pre-merge checks | ✅ 5 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'Bloomknights' does not follow the required format of starting with an issue number in brackets (e.g., '[#455]'). Update the title to '[#455] Add BloomKnights site with animations and optimized assets' (or similar) to include the linked issue number and a concise description.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Out of Scope Changes check ❓ Inconclusive The PR also includes minor formatting fixes (punctuation/comment updates) in existing blade app files unrelated to BloomKnights, along with cron builder whitespace cleanup. Clarify whether the formatting changes in blade files (FAQ punctuation, comment style updates, UI labels) are intentional polish or should be split into a separate PR for clearer scope.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR implements BloomKnights site with animated components, optimized graphics, and CDN/R2 caching, fully addressing the objectives described in linked issue #455.
No Hardcoded Secrets ✅ Passed No hardcoded API keys, passwords, tokens, or secrets found. All configuration files properly reference environment variables or contain only public data (URLs, SEO metadata, package dependencies).
Validated Env Access ✅ Passed No direct process.env usage found outside of config files; all hardcoded values centralized in seo.ts following validated env patterns.
No Typescript Escape Hatches ✅ Passed No TypeScript escape hatches found. Comprehensive scan of 35 bloomknights source files found zero instances of any, @ts-ignore, @ts-expect-error, or non-null assertions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bloomknights

@Adr1an04 Adr1an04 requested a review from DVidal1205 May 31, 2026 16:35
Copy link
Copy Markdown
Contributor

@DVidal1205 DVidal1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet lgtm

@DVidal1205 DVidal1205 merged commit f970aa1 into main May 31, 2026
10 of 11 checks passed
@DVidal1205 DVidal1205 deleted the bloomknights branch May 31, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BloomKnights

4 participants