Bloomknights#456
Merged
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR adds the BloomKnights event website as a new Next.js app within the Forge monorepo, complete with animated graphics, interactive sections, and global styling. Concurrently, UI text is standardized across Blade and 2025 apps by replacing em-dashes with commas and normalizing missing-value placeholders to "No response." ChangesBloomKnights Event Website
Blade and 2025 Apps: UI Text Updates
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #455
Why
BloomKnights is currently its own branch of visual/site work, and this PR packages that work so it can land before the hackathon form frontend branch that builds on top of it.
What
Test Plan
pnpm formatpnpm lintpnpm typecheckpnpm lint:wsWhat you should test
Warning
The hackathon itself has not been made, so the link on https://blade.knighthacks.org/hacker/application/bloomknights does not work. in the next pr we will make the hackathon on prod and test the system for applying.
Video
Screen.Recording.2026-05-31.at.10.28.21.AM.1.mp4
Summary by CodeRabbit
New Features
Style
Chores