docs: the ladder's framework-gap lists are entirely obsolete - #278
Merged
Conversation
Combines morph#269 and morph#270: both target examples/polls/README.md, so splitting them into two PRs would have meant resolving conflicts between my own branches over the same paragraphs. TESTING.md's "Framework gaps this strategy exposes (candidate issues)" listed six items. #269 reports the first two as shipped. Checking the other four found the same thing -- every item on the list has shipped: 1. client-side execute deadline -> Bridge::setExecuteDeadline (bridge.hpp) 2. Bridge::pendingCalls() -> bridge.hpp 3. MainThreadExecutor::runOnce()/drain() -> executor.hpp:180, :204 4. QtExecutor with an optional QObject* context target -> QtExecutor(QObject* context = QCoreApplication::instance()) (qt_executor.hpp:60) 5. connection-scoped simulated client -> RemoteServer::openConnection() (remote.hpp:336) 6. injectable time source -> setNowOverride / ScopedNowOverride (util/datetime.hpp) The list is kept, retitled, and each entry now names where the capability lives. It records what the testing strategy pushed the framework to grow, which is worth keeping; what it must not do is read as work to schedule. polls/README.md's "Framework prerequisites" section (morph#270) had the same problem plus an internal contradiction: its own heading says the two items were "built as part of this rung", while the body said both were "confirmed still open by direct inspection". Both shipped -- this rung built them. The bullets now say so and point at the symbols. Two related sites in the same file follow from that: the "WASM + shared handlers may not work at all today [framework prerequisite]" strain point (the synchronous path still aborts the page, but the async pair exists, so it is not a prerequisite), and the polling-helper strain point that cited the silent drop. Distinctions kept rather than flattened: the synchronous shared/keyed attach path *does* still nest an event loop and still aborts on WASM -- only the "missing prerequisite" half is stale. And the async path's behaviour in a browser has still never been observed, only its compilation, so the "run the several-WASM-tabs demo literally" advice stands. Every symbol and path written here was confirmed present first. Closes #269 Closes #270
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #269.
Closes #270.
Combined deliberately: both target
examples/polls/README.md, so splittingthem into two PRs would have meant resolving conflicts between my own branches
over the same paragraphs.
The whole list is obsolete, not two entries of it
TESTING.md's "Framework gaps this strategy exposes (candidate issues)" listssix items. #269 reports the first two as shipped. Checking the other four found
the same thing — every item on the list has shipped:
Bridge::setExecuteDeadline(bridge.hpp)Bridge::pendingCalls()bridge.hppMainThreadExecutor::runOnce()/drain()executor.hpp:180,:204QtExecutorwith optionalQObject*contextQtExecutor(QObject* context = QCoreApplication::instance())(qt_executor.hpp:60)RemoteServer::openConnection()(remote.hpp:336)setNowOverride/ScopedNowOverride(util/datetime.hpp)The list is kept and retitled, with each entry naming where the capability lives.
It records what the testing strategy pushed the framework to grow — worth
keeping. What it must not do is read as work to schedule.
polls/README.md contradicted itself
Its "Framework prerequisites" heading says the two items were "built as part of
this rung", while the body said both were "confirmed still open by direct
inspection of the current framework source". Both shipped — this rung built
them. The bullets now say so and point at the symbols.
Two related sites in the same file follow from that: the "WASM + shared handlers
may not work at all today [framework prerequisite]" strain point, and the
polling-helper strain point that cited the silent drop.
Distinctions kept rather than flattened
loop and still aborts the page on WASM. Only the "missing prerequisite" half is
stale — a WASM client must still avoid it and use the async pair.
compilation. So "run the several-WASM-tabs demo literally" still stands.
Every symbol and path written here was confirmed present first — 12 symbols
across 6 headers.
Related
Sixth and seventh instances of this defect class. #271 (
LADDER.md) is #273 —which now also carries one more site this grep turned up, since that PR already
owns the file. #272 (
TESTING.md's "verified" list) is #274, in a differentsection of the same file with no overlap.
Documentation only;
scripts/check_spec_citations.shpasses.