Tolerate floating-point rounding in friction pressure-drop assert by MatthiasBSchaefer · Pull Request #3 · LTX-Shadow/ModelicaStandardLibrary

MatthiasBSchaefer · 2026-07-13T13:33:56Z

Backport of modelica#4791 into this fork

Summary by CodeRabbit

Summary of changes

Bug Fixes
- Improved validation of nominal pressure-drop parameters using a tolerance-adjusted check to prevent false failures from minor floating-point rounding differences.
Documentation / Chores
- Added a small informational/reminder line to the header comment of a bundled C source component (no functional impact).

Backport of modelica#4791 into this clone

coderabbitai · 2026-07-13T13:34:52Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e0a4f151-b9c1-45f5-93a1-0b61efcf48b9

📥 Commits

Reviewing files that changed from the base of the PR and between 8bad774 and de19205.

📒 Files selected for processing (1)

Modelica/Resources/C-Sources/ModelicaMatIO.c

🚧 Files skipped from review as they are similar to previous changes (1)

Modelica/Resources/C-Sources/ModelicaMatIO.c

📝 Walkthrough

Walkthrough

SimpleFriction now validates dpNominal against an epsilon-adjusted threshold, reformats pressure-drop equations, and adds an informational line to the ModelicaMatIO.c header comment.

Changes

Friction parameter validation

Layer / File(s)	Summary
Relax nominal pressure-drop assertion `Modelica/Thermal/FluidHeatFlow/BaseClasses/SimpleFriction.mo`	The initialization assertion uses an epsilon-adjusted lower bound, and pressure-drop expressions are reformatted without calculation changes.

Source header comment

Layer / File(s)	Summary
Add source header remark `Modelica/Resources/C-Sources/ModelicaMatIO.c`	An informational reminder line is added to the header comment without functional code changes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: relaxing the friction pressure-drop assertion to tolerate floating-point rounding.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch MatthiasBSchaefer-PR4791

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

MSL-RegressionTesting-CI

Please look here for details:https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

Removed an unnecessary remark from the comments.

MSL-RegressionTesting-CI

Please look here for details: https://serv.ltx.de/prs//3/Modelica/PR_comparison_report.html and https://serv.ltx.de/prs//3/ModelicaTest/PR_comparison_report.html

MSL-RegressionTesting-CI · 2026-07-23T08:56:27Z

C code changes detected. Please add 'secure-c-code' label to the pr and rerun the workflow

MSL-RegressionTesting-CI · 2026-07-23T09:26:40Z

C code changes detected. Please add 'secure-c-code' label to the pr and rerun the workflow

MSL-RegressionTesting-CI · 2026-07-23T09:38:30Z

C code changes detected. Please add 'secure-c-code' label to the pr and rerun the workflow

Tolerate floating-point rounding in friction pressure-drop assert

4859031

Backport of modelica#4791 into this clone

MSL-RegressionTesting-CI approved these changes Jul 13, 2026

View reviewed changes

MSL-RegressionTesting-CI approved these changes Jul 15, 2026

View reviewed changes

MSL-RegressionTesting-CI suggested changes Jul 16, 2026

View reviewed changes

MSL-RegressionTesting-CI suggested changes Jul 17, 2026

View reviewed changes

MSL-RegressionTesting-CI suggested changes Jul 18, 2026

View reviewed changes

MSL-RegressionTesting-CI approved these changes Jul 18, 2026

View reviewed changes

Fix spacing in pressureDrop calculations

ea178d7

MSL-RegressionTesting-CI suggested changes Jul 22, 2026

View reviewed changes

Remove irrelevant remark from ModelicaMatIO.c

8bad774

Removed an unnecessary remark from the comments.

MSL-RegressionTesting-CI suggested changes Jul 22, 2026

View reviewed changes

MatthiasBSchaefer added the secure-c-code mark, that the changes in the c code are not malicious label Jul 23, 2026

Update remark in ModelicaMatIO.c

de19205

Uh oh!

Conversation

MatthiasBSchaefer commented Jul 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary of changes

Uh oh!

coderabbitai Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI left a comment

Choose a reason for hiding this comment

Uh oh!

MSL-RegressionTesting-CI commented Jul 23, 2026

Uh oh!

MSL-RegressionTesting-CI commented Jul 23, 2026

Uh oh!

MSL-RegressionTesting-CI commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

MatthiasBSchaefer commented Jul 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading