Share permission lists across core roles#7847
Merged
Merged
Conversation
labkey-jeckels
approved these changes
Jul 15, 2026
| } | ||
|
|
||
| @Override | ||
| public boolean isApplicable(SecurableResource resource) |
Contributor
There was a problem hiding this comment.
Moving this method is a small functional change but presumably intentional.
Contributor
Author
There was a problem hiding this comment.
I inverted the hierarchy so EditorRole now inherits from EditorWithoutDeleteRole. So a couple methods had to move to the latter.
Claude isn't thrilled with this change (instanceof semantics will change), but it makes more sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Core roles (RestrictedReaderRole -> ReaderRole -> AuthorRole -> EditorWithoutDeleteRole -> EditorRole), share common permissions but their actual permission lists are duplicated in each class. This can easily lead to mistakes. A better approach is for the roles to share permission lists, each role adding just the permissions it needs to add. This is similar to the way we build the permission lists for admin roles.
Tasks