Skip to content

Update for cageUI project#968

Merged
dnicolalde merged 17 commits into
release26.3-SNAPSHOTfrom
26.3_fb_cageUI_patch_v1
Jun 22, 2026
Merged

Update for cageUI project#968
dnicolalde merged 17 commits into
release26.3-SNAPSHOTfrom
26.3_fb_cageUI_patch_v1

Conversation

@LeviCameron1

Copy link
Copy Markdown
Collaborator

Rationale

Additional changes brought up by Erika and some bug fixes.

Related Pull Requests

Changes

  1. Ability to unmerge racks
  2. Add new divider locked modification (one red line)
  3. Update room list navigation to show current url position and save during refreshing
  4. Bug fix for template rooms preventing connecting cages.
  5. Add loading into the room display when switching rooms.
  6. Sort room list racks based on their cage numbers
  7. Fix room list drop-down so that they can close
  8. Update svg fetching to cut back on loading times.
  9. Fix room list scroll so that it doesn’t obscure drop-downs

@LeviCameron1
LeviCameron1 requested a review from dnicolalde June 5, 2026 15:33

@dnicolalde dnicolalde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dnicolalde
dnicolalde merged commit ffc956c into release26.3-SNAPSHOT Jun 22, 2026
6 of 9 checks passed
@dnicolalde
dnicolalde deleted the 26.3_fb_cageUI_patch_v1 branch June 22, 2026 17:36
dnicolalde pushed a commit that referenced this pull request Jun 22, 2026
#### Rationale
Additional changes brought up by Erika and some bug fixes.

#### Related Pull Requests

#### Changes

1. Ability to unmerge racks
2. Add new divider locked modification (one red line)
3. Update room list navigation to show current url position and save
during refreshing
4. Bug fix for template rooms preventing connecting cages.
5. Add loading into the room display when switching rooms.
6. Sort room list racks based on their cage numbers
7. Fix room list drop-down so that they can close
8. Update svg fetching to cut back on loading times.
9. Fix room list scroll so that it doesn’t obscure drop-downs
dnicolalde pushed a commit that referenced this pull request Jun 30, 2026
#### Rationale
cageui_svg_urls line in lookup_sets (added as part of related PR) uses
spaces instead of tab causing TC failure:


https://teamcity.labkey.org/buildConfiguration/LabKey_263Release_External_Wnprc_WnprcEhrPostgres2/4068462?expandedTest=build%3A%28id%3A4068462%29%2Cid%3A2000000006

org.openqa.selenium.NoSuchElementException: Expected condition failed:
waiting for xpath=//div[contains(text(), 'Delete Complete')]

#### Related Pull Requests
* #968

#### Changes
* Use tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants