docs: fix broken threat model link in SECURITY.md and a typo - #833
Merged
Conversation
SECURITY.md linked security/threat-model.md (hyphen); the file in the repository is security/threat_model.md (underscore). tools/shell/shell_development_guide.md: avaiable -> available.
Contributor
|
Thank you for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small docs fixes, verified against the current tree on
main.Broken link.
SECURITY.md:17points atsecurity/threat-model.md, but the file in the repository issecurity/threat_model.md— hyphen vs. underscore, so the link 404s.Typo.
tools/shell/shell_development_guide.md:138— "due to the whole query being avaiable" → "available".One thing I did not change, since the fix isn't obvious:
docs/testing.md:42links to../tools/nodejs_api/docs/nodejs_testing.mdas the "Node.js API — Testing Guide".tools/nodejs_api/exists, but it has nodocs/directory and no markdown files at all, so there's no obvious intended target. Let me know if the guide moved or is still to be written and I'll follow up.