Improve fan-out release_stake#133
Open
ismellike wants to merge 3 commits into
Open
Conversation
- Add state cleanup in release_unbonded when locked is zero - Call release_unbonded after release_stake for the staker
State is now cleaned up in release_unbonded
ueco-jb
reviewed
Jan 3, 2025
Comment on lines
-125
to
+126
| self.locked - self.max_lien, | ||
| self.locked - self.total_slashable, | ||
| self.locked.saturating_sub(self.max_lien), | ||
| self.locked.saturating_sub(self.total_slashable), |
Member
There was a problem hiding this comment.
What would be a valid case where there are less locked tokens then the max lien? The slashing scenario should be covered with total_slashable anyway, shouldn't it?
Collaborator
Author
There was a problem hiding this comment.
Not really any "valid" case. I changed this as an extra layer of security.
ueco-jb
approved these changes
Jan 3, 2025
Member
ueco-jb
left a comment
ueco-jb
left a comment
There was a problem hiding this comment.
The code is legit, I'm only worried about that addition of saturating_sub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #126