Fix/mos 0005#10
Merged
Merged
Conversation
… lines) - Remove 'Learning Notes' and historical comments not appropriate for production - Condense method documentation to concise single-line or 3-4 line Javadocs - Remove redundant inline comments and excessive log statements - No logic changes all code paths identical
- Extract batchFetchPrices() to share one DB query between buildTimeline() and buildHoldingsTimelines() - buildHoldingsTimelines() now filters the pre-fetched price map in memory instead of issuing per-holding findByAssetIdAndDateBetween queries - Update test mocks to use findByAssetIdsAndDateBetween (batch)
- Add findDatesByAssetIdAndDateBetween() to AssetPriceRepository - Replace per-record existsByAssetIdAndDate() + save() with: 1. One query to fetch existing dates as a Set 2. In-memory filter against that Set 3. Single saveAll() for new prices - Reduces DB round-trips from 2N to 2 per asset
- Add rateLimiterLock object and wrap enforceRateLimit() in synchronized block - Prevents race condition on currentMinuteStart/requestsInCurrentMinute if called from multiple threads (e.g. scheduler + manual trigger) - Clean up emoji characters from log messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.