Fix/mos 0007#12
Merged
Merged
Conversation
- SPY data available portfolio values correctly scaled to SPY growth - SPY data empty falls back to 10% CAGR calculation - SPY fetch throws exception CAGR fallback, no exception propagates - Repository exception same CAGR fallback - CAGR math verified: 2-year period 21% growth - Timeline delegates to TimelineAggregator
Plain unit tests (no Spring context): - Empty/single-point edge cases for every Timeframe value - ONE_DAY: returns all points unchanged - ONE_WEEK: samples first day of each ISO week, reduces count - ONE_MONTH: samples first day of each month, 12 per year - ONE_YEAR: samples first day of each year - ALL/smart: 500 returns unchanged; 3000 points capped near 500; always includes last point; preserves chronological order
…nResults - InvestmentBuilder.test.tsx: 7 tests covering form rendering, adding investments, validation states, simulation button behavior - SimulationResults.test.tsx: 11 tests covering metric cards, currency formatting, profit/loss styling, holdings table, chart rendering, disclaimer display - Mock PortfolioChart (canvas-based) and PortfolioHeader components - Use within() scoping for assertions on duplicated text across sections - Total frontend tests: 90 (72 existing + 18 new)
- Change CI from 'npm run test' to 'npm run test:coverage' - Upload coverage report as artifact (frontend-coverage, 14-day retention) - Coverage thresholds enforced at 30% (statements, branches, functions, lines) - Current coverage: 62% statements, 56% branches, 48% functions, 64% lines - Backend JaCoCo remains disabled (incompatible with Java 25)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.