Fix/mos 0012#17
Merged
Merged
Conversation
- Trigger button shows only the ticker symbol (same height as Amount and Date inputs, fixing row alignment) - Company name displayed as a subtle label below the trigger - Dropdown option display unchanged (full symbol + name + sector)
- Track per-investment 'isNew' IDs in InvestmentBuilder (Set<string>) - New rows added via '+' are marked as new; validation errors hidden - Interacting with any field clears the isNew flag for that row - Clicking Simulate clears all isNew flags to reveal errors everywhere - No changes to the Investment type (isNew is local UI state only)
- Info icon (ℹ) appears next to 'Purchase Date' label when asset has an IPO date hover shows 'MSFT available from Mar 13, 1986' - Date input min attribute set to IPO date so native picker greys out earlier dates - Existing error message kept as fallback for manual date entry - 107 tests pass, tsc clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.