Fix intermittent 401 by reducing default JWT expiry and fix --duration flag#68
Open
gpailler wants to merge 2 commits intoLink-:mainfrom
Open
Fix intermittent 401 by reducing default JWT expiry and fix --duration flag#68gpailler wants to merge 2 commits intoLink-:mainfrom
gpailler wants to merge 2 commits intoLink-:mainfrom
Conversation
GitHub rejects JWTs with an 'exp' claim more than 10 minutes in the future. With a 10-minute default, even a few seconds of clock drift on the client machine causes intermittent 401 errors. Reducing to 5 minutes provides a comfortable buffer while still being long enough for any practical use.
The code read "jwt-expiry" but the flag is registered as "duration", so the value was always 0 and then default 10 was used. Also update the flag description to reflect the new default of 5 minutes and remove the part about "useful when using --jwt" because the duration applies to all JWT generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--duration/-dflag being silently ignored due to a name mismatch (c.Int("jwt-expiry")vs flag registered as"duration")