LKE-14893: Expose plugin actions#35
Draft
gmasclet wants to merge 1 commit into
Draft
Conversation
gmasclet
force-pushed
the
LKE-14893-expose-plugin-actions
branch
from
4255f0d to
06d53bb
Compare
gmasclet
commented
May 20, 2026
| isAdmin: boolean; | ||
| } | ||
|
|
||
| export class API extends WithLogger { |
Contributor
Author
There was a problem hiding this comment.
Maybe I'm missing something, but I feel the API is an empty shell which doesn't bring actual value.
| import {Logger, WithLogger} from '../services/logger'; | ||
|
|
||
| interface PluginOptions extends PluginRouteOptions<MyPluginConfig> { | ||
| ipcClient?: IpcClient; |
Contributor
Author
There was a problem hiding this comment.
defined as optional, so that the plugin stays compatible with former LKE hosts.
| actions: [ | ||
| { | ||
| name: 'Configure integrations', | ||
| urlTemplate: `{{baseURL}}plugins/${basePath}/`, |
Contributor
Author
There was a problem hiding this comment.
We may also consider providing a template that is relative to the plugin base path (and let the server resolve the absolute URL if needs be).
Suggested change
| urlTemplate: `{{baseURL}}plugins/${basePath}/`, | |
| urlTemplate: '/', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ref.: https://linkurious.atlassian.net/browse/LKE-14893
Description
🚧 Work in progress 🚧
Demonstrate how https://github.com/Linkurious/linkurious-server/pull/6220 can be used.
This PR is not complete: here, the plugin is still creating regular custom actions. We should remove that logic if the IPC client is defined.