Open
Conversation
Drop the optional popplerqt5/python3-poppler-qt5 dependency and the associated LIB_BAD guard. Use QPdfDocument from PyQt6.QtPdf instead, which ships as part of PyQt6 itself. Rendering now uses QPdfDocumentRenderOptions with Antialiasing and TextAntialiasing flags set, preserving the render quality of the original poppler-based code. Other PyQt6 migration changes: - app.exec_() replaced with app.exec() - pageCount()/pagePointSize()/render() replace numPages()/page()/renderToImage()
Contributor
In that case you might want to mark this PR as 'Draft'' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a completely mechanical conversion from PyQt5 to PyQt6. This is not tested to run successfully yet.