Skip to content

fix: harden Windows broker uninstall and release CI - #67

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/release-prep-02
Aug 13, 2026
Merged

fix: harden Windows broker uninstall and release CI#67
ReenigneArcher merged 1 commit into
masterfrom
fix/release-prep-02

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Aug 12, 2026

Copy link
Copy Markdown
Member

Description

Strengthens Windows reliability and release safety by making driver uninstall failures explicit, verifying broker/service/package cleanup, and improving broker pipe reconnection handling for transient pipe states. Adds extensive Windows broker client/service tests (including persistence and Polar transport failure injection), updates CI coverage exclusions, signing-identity and release-artifact validation, and aligns docs/artifact naming with AMD64-only installer limits.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.44%. Comparing base (766a0e2) to head (fb8fe46).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   74.60%   74.44%   -0.16%     
==========================================
  Files          34       33       -1     
  Lines        7931     7858      -73     
  Branches     2984     2952      -32     
==========================================
- Hits         5917     5850      -67     
- Misses       1733     1740       +7     
+ Partials      281      268      -13     
Flag Coverage Δ
Linux-Clang 56.49% <ø> (-0.64%) ⬇️
Linux-GCC 67.39% <ø> (-0.53%) ⬇️
Windows-MSVC 87.88% <100.00%> (+<0.01%) ⬆️
Windows-MinGW-UCRT64 64.22% <92.00%> (-0.33%) ⬇️
macOS 50.21% <ø> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/windows_broker_client.cpp 93.23% <100.00%> (+6.99%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 766a0e2...fb8fe46. Read the comment docs.

@ReenigneArcher
ReenigneArcher force-pushed the fix/release-prep-02 branch 6 times, most recently from 3045d09 to feac0c2 Compare August 13, 2026 00:27
Strengthens Windows reliability and release safety by making driver uninstall failures explicit, verifying broker/service/package cleanup, and improving broker pipe reconnection handling for transient pipe states. Adds extensive Windows broker client/service tests (including persistence and Polar transport failure injection), updates CI coverage exclusions, signing-identity and release-artifact validation, and aligns docs/artifact naming with AMD64-only installer limits.
@ReenigneArcher ReenigneArcher changed the title fix: harden uninstall and add broker service tests fix: harden Windows broker uninstall and release CI Aug 13, 2026
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 930a8d6 into master Aug 13, 2026
29 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/release-prep-02 branch August 13, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant