refactor(Windows): mark protocol headers C++-only - #73
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 74.76% 74.70% -0.07%
==========================================
Files 33 33
Lines 7910 7906 -4
Branches 2968 2966 -2
==========================================
- Hits 5914 5906 -8
+ Misses 1658 1421 -237
- Partials 338 579 +241
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
ReenigneArcher
force-pushed
the
fix/release-prep-05
branch
2 times, most recently
from
August 14, 2026 03:44
0d50743 to
2329208
Compare
Update the shared Windows protocol headers to explicitly be C++-only and remove legacy C compatibility paths. This drops the `#else` constant/enums and `extern "C"` wrappers, leaving a single C++ definition path with `inline constexpr`, scoped enums, and the existing packed protocol structs.
ReenigneArcher
force-pushed
the
fix/release-prep-05
branch
from
August 14, 2026 03:50
2329208 to
8a26ec7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Update the shared Windows protocol headers to explicitly be C++-only and remove legacy C compatibility paths. This drops the
#elseconstant/enums andextern "C"wrappers, leaving a single C++ definition path withinline constexpr, scoped enums, and the existing packed protocol structs.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.