Skip to content

fix(Crowdin): whitespace loss after translation - #328

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/crowdin/whitespace
Aug 11, 2026
Merged

fix(Crowdin): whitespace loss after translation#328
ReenigneArcher merged 1 commit into
masterfrom
fix/crowdin/whitespace

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Aug 11, 2026

Copy link
Copy Markdown
Member

Description

Preserves spacing around inline elements after Crowdin translation by capturing text-node boundaries, restoring them in a translator callback, and observing later DOM mutations for async updates. Also updates tests to cover supported translator options and whitespace restoration edge cases. For docs examples, Jekyll now copies shared-web dist assets into the build output and references them via /assets/shared-web, while Sphinx loads shared-web assets from node_modules and narrows rstcheck linting to the source directory.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 1.49kB (12.07%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
shared-web-array-push 13.81kB 1.49kB (12.07%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: shared-web-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
crowdin.js 1.49kB 4.88kB 43.85% ⚠️

Files in crowdin.js:

  • ./src/js/crowdin.js → Total Size: 10.99kB

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a618a71) to head (6532a22).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #328   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          127       181   +54     
  Branches        35        54   +19     
=========================================
+ Hits           127       181   +54     
Files with missing lines Coverage Δ
src/js/crowdin.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a618a71...6532a22. Read the comment docs.

@ReenigneArcher
ReenigneArcher force-pushed the fix/crowdin/whitespace branch 2 times, most recently from 451d993 to c85bef1 Compare August 11, 2026 20:45
@ReenigneArcher ReenigneArcher changed the title fix(Crowdin): anable whitespace cleanup fix(Crowdin): whitespace loss after translation Aug 11, 2026
Preserves spacing around inline elements after Crowdin translation by capturing text-node boundaries, restoring them in a translator callback, and observing later DOM mutations for async updates. Also updates tests to cover supported translator options and whitespace restoration edge cases. For docs examples, Jekyll now copies shared-web dist assets into the build output and references them via /assets/shared-web, while Sphinx loads shared-web assets from node_modules and narrows rstcheck linting to the source directory.
@ReenigneArcher
ReenigneArcher force-pushed the fix/crowdin/whitespace branch from c85bef1 to 6532a22 Compare August 11, 2026 20:58
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review August 11, 2026 21:03
@ReenigneArcher
ReenigneArcher merged commit a7ccbee into master Aug 11, 2026
16 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/crowdin/whitespace branch August 11, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant