Synced the whole branch with the official repo and requested to merge DataPath.cs#3155
Synced the whole branch with the official repo and requested to merge DataPath.cs#3155Andy-177 wants to merge 2 commits into
Conversation
# Submission Instructions
## Content of this submission
### 1. Synchronize official CSharpRunner.cs
- Synchronize `CSharpRunner.cs` to the latest official version
- **Removed** extended support for non-standard metadata formats (XML, C# style, JS style)
- Restore to the official standard metadata parsing method
### 2. Migrate DataPath.cs
- Migrate `DataPath.cs` to the new version of the code repository
- Maintain the original functionality unchanged:
- `DataPath.Init("ScriptName")` - create a configuration folder
- `DataPath.Get()` - Gets the path of the configuration folder
## Reason for change
1. **Facilitate official merging**: Retaining custom metadata formats increases the risk of conflicts with the official codebase. Removing them allows for smoother acceptance of official updates
2. **Reduce maintenance costs**: The official CSharpRunner.cs undergoes frequent changes, making the maintenance of custom branches a significant workload
3. **Maintain consistency**: Keep consistent with the official version to avoid compatibility issues caused by format differences
## Scope of impact
- Previously supported non-standard metadata formats (XML, C# style, JS style) will no longer be recognized
- Only supports official standard metadata formats
- The functionality of DataPath.cs remains unaffected, and the configuration management function is still operational and available
## Remarks
- DataPath.cs and CSharpRunner.cs have previously been modified, and this time it is only for migration and synchronization purposes
- AI-assisted participation was involved in the previous modification process
|
Hello, |
This PR was opened by me personally, not by any automated agent. I implemented the new features described above. My English isn't great, so I used machine translation for most of the description — feel free to ask if something doesn't make sense. |
|
@milutinke milutinkeI believe Minecraft-console-client would benefit from a feature that makes it easier for scripts to manage and store configuration files. I actually built this feature in my personal fork a couple of years ago with the help of AI, and I'm now hoping to get it merged into the mainline. |
|
@Andy-177 The PR only adds |
Updated comments to include English translations for clarity.
Regarding this PR, the explanation is as follows:
I have updated the PR text to English instructions as per your request, and ensured that all comments are bilingual in both Chinese and English. Please review them, thank you! |
2 participants
Pull Request Description
Summary
This PR synchronizes
CSharpRunner.cswith the latest official version and migratesDataPath.csto the new codebase. It also removes support for non-standard metadata formats to ensure compatibility with the official branch.Changes Made
🔄 Synchronize CSharpRunner.cs
<ScriptMeta>...</ScriptMeta>)scriptmeta { ... })scriptmeta { ... })📦 Migrate DataPath.cs
DataPath.csto the current codebaseDataPath.Init("ScriptName")— creates a configuration folderDataPath.Get()— returns the configuration folder pathRationale
CSharpRunner.cschanges frequently; maintaining a forked version is costlyImpact & Breaking Changes
✅ Unaffected
DataPath.csconfiguration management functions remain unchangedMigration Notes
If your scripts currently use custom metadata formats, please convert them to the official format before merging this PR.
Additional Context
DataPath.csandCSharpRunner.cshave been modified in previous iterations; this PR focuses purely on migration and synchronizationChecklist