Updates to wheel deployment workflow#5386
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5386 +/- ##
========================================
Coverage 93.85% 93.86%
========================================
Files 182 182
Lines 22509 22509
Branches 3202 3202
========================================
+ Hits 21125 21127 +2
+ Misses 922 921 -1
+ Partials 462 461 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add arm wheels, update windows minimum version, and small cleanup.
IAlibay
changed the title
| - [ubuntu-24.04-arm, manylinux, aarch64] | ||
| - [windows-2025, win_amd64, amd64] | ||
| - [macos-14, macosx, arm64] | ||
| - [macos-15-intel, macosx, x86_64] |
There was a problem hiding this comment.
Do we really want to target builds for intel macs? Can't builds for those be dropped and if someone requires it they can always build themselves?
There was a problem hiding this comment.
My take is here is "why not" - there's not really a cost to having them. Is the concern mostly that we don't test it anymore?
There was a problem hiding this comment.
I'd still build them as long as it does not break our system. Not everyone can afford upgrading their laptop every 3 years (yes, M1 was ~2020...) and so providing our software on older architectures makes it more accessible.
There was a problem hiding this comment.
I mention mostly because Blender has dropped providing explicit binaries for Intel Mac's because of the development burden. As long as it's not breaking anything then I suppose why not, but I think if it starts causing issues we drop it.
There was a problem hiding this comment.
My suggestion is that we add intel osx back into the cron test matrix. I am a little bit wary that we've not run tests with it in a while, so have it solely in deployment seems risky.
| type: ["FULL", "MIN"] | ||
| exclude: | ||
| # Multiple deps don't like windows | ||
| # macos doesn't like HOLE2 |
There was a problem hiding this comment.
There's a OSX-64 package https://anaconda.org/channels/conda-forge/packages/hole2/files but I guess no osx-arm.
There was a problem hiding this comment.
That's a good point, let me update that comment to osx-arm64.
| pull_request: | ||
| branches: | ||
| - "package-*" | ||
| - "develop" |
4 participants
Fixes #
Changes made in this Pull Request:
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes / no
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5386.org.readthedocs.build/en/5386/