ChartEx (cx:) modern charts — Phase A round-trip + Phase B Waterfall writer (Refs #14)#56
Merged
Merged
Conversation
…e B Waterfall writer — issue #14 Manual semantic port of the GetThematic/python-pptx master ChartEx implementation (the epic's named highest-quality cherry-pick candidate) onto this fork's ruff-formatted master. Never cherry-picked (repo §2): the diff was re-derived against current master (#19/#25 merged) and applied as additive shims onto the diverged wiring files. Delivered: - Phase A — cx: round-trip preservation for ALL chartEx types. A deck containing a PowerPoint-authored waterfall/treemap/sunburst/etc. opens, edits unrelated slides, and saves without corrupting the chartEx part. mc:AlternateContent/mc:Choice unwrap in CT_GroupShape.iter_shape_elms. - Phase B — Waterfall WRITER. add_chartex(WaterfallChartData, x,y,cx,cy) and a thin add_chart(XL_CHART_TYPE.WATERFALL, ...) dispatch shim. - Foundation: cx + mc namespaces (ns.py), RT.CHARTEX/CHART_STYLE (constants.py), GRAPHIC_DATA_URI_CHARTEX (spec.py), 28 cx: oxml element classes registered (oxml/__init__.py), ChartExPart/ChartStylePart/ ChartColorStylePart part-factory wiring (__init__.py), new oxml/chart/chartex.py, chart/chartex.py, parts/chartex.py, and WaterfallChartData in chart/data.py. - XL_CHART_TYPE extended: WATERFALL (writable) + TREEMAP/SUNBURST/FUNNEL/ BOX_WHISKER/HISTOGRAM/PARETO. The six non-waterfall types raise NotImplementedError from add_chart (round-trip only); writers tracked as a Phase C follow-up (uat/FOLLOWUP_issue14_phaseC_writers.md). Adaptation notes: - GetThematic's cxml.py changes deliberately NOT ported: they migrate to pyparsing-3 APIs but this fork pins pyparsing<3 (2.4.7). The existing generic-grammar cxml.py already parses cx: tags; porting would break. - Treemap/Sunburst writers do not exist in GetThematic; shipping unvalidated hand-authored cx: OOXML would violate round-trip safety. Tests (this fork, .venv toolchain): - pytest: 3812 passed, 0 failed (3761 baseline + 51 new chartex tests). - ruff check src tests: All checks passed; ruff format: fixed point. - behave: 1094 scenarios passed, 0 failed (32 new cx: scenarios across cht-chartex-{waterfall,roundtrip,types}.feature; baseline preserved). UAT (maintainer-gated, NOT signoff): uat/uat_cx_modern_charts.py builds a multi-slide waterfall deck + round-trip read-back, exits non-zero on failure. Agent ran it for QA-on-the-test only; visual signoff in PowerPoint/Keynote remains the maintainer's (repo §6a). Port provenance: GetThematic/python-pptx master (clean waterfall + chartEx round-trip). Refs #14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase A + Phase B of the #14 epic (Modern Charts via
cx:namespace). Refs #14 — does not close the epic; Phase C (remaining writers + cx:replace_data) is tracked separately.What ships
Manual semantic port of
GetThematic/python-pptxmaster ChartEx (the epic's named highest-quality cherry-pick candidate) onto this fork's ruff-formatted, #19/#25-diverged master. Nevergit cherry-picked (repo §2) — the diff was re-derived and applied as additive shims.cx:types. A deck containing a PowerPoint-authored waterfall/treemap/sunburst/etc. opens, edits unrelated slides, and saves without corrupting the chartEx part.mc:AlternateContent/mc:Choiceunwrap inCT_GroupShape.iter_shape_elms. Round-trip proven c14n byte-identical for unmodeled elements (treemap-shaped part with unmodeled<cx:parentLabelLayout>+ hierarchical<cx:lvl>).slide.shapes.add_chartex(WaterfallChartData, x,y,cx,cy)and a thinadd_chart(XL_CHART_TYPE.WATERFALL, …)dispatch shim.cx+mcnamespaces,RT.CHARTEX/CHART_STYLE,GRAPHIC_DATA_URI_CHARTEX, 28cx:oxml element classes,ChartExPart/ChartStylePart/ChartColorStylePartpart-factory wiring, newoxml/chart/chartex.py+chart/chartex.py+parts/chartex.py,WaterfallChartData.XL_CHART_TYPEextended:WATERFALL(writable) +TREEMAP/SUNBURST/FUNNEL/BOX_WHISKER/HISTOGRAM/PARETO(values ≥1000, fork-private — the MS COM enum predates chartEx). The six non-waterfall types raiseNotImplementedErrorfromadd_chart(round-trip only).docs/user/charts.rstChartEx section +docs/api/enum/XlChartType.rstmembers.Deliberately deferred to Phase C (follow-up issue)
Treemap/Sunburst/Funnel/Box-Whisker/Histogram/Pareto writers and a cx:
replace_dataAPI. GetThematic ships none of these; hand-authoring unvalidated<cx:treemap>OOXML would violate the round-trip-safety principle. Draft follow-up:uat/FOLLOWUP_issue14_phaseC_writers.md.Tests (
.venvtoolchain)3813 passed in 6.35s(3761 baseline + 52 new chartex tests, 0 failed)All checks passed!(src tests); format at fixed point1094 scenarios passed, 0 failed(32 new cx: scenarios)UAT:
uat/uat_cx_modern_charts.py(10/10 script-QA) — maintainer visual signoff received in PowerPoint/Keynote.Adaptation note: GetThematic's
tests/unitutil/cxml.pypyparsing-3 changes were deliberately not ported — this fork hard-pinspyparsing<3; the existing generic-grammar cxml already handlescx:tags.Port provenance: GetThematic/python-pptx master. Refs #14.