Reranker

[JPrevost]

Developer

Accessibility

• ANDI or WAVE has been run in accordance to our guide.
• This PR contains no changes to the view layer.
• New issues flagged by ANDI or WAVE have been resolved.
• New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
• No new accessibility issues have been flagged.

New ENV

• All new ENV is documented in README.
• All new ENV has been added to Heroku Pipeline, Staging and Prod.
• ENV has not changed.

Approval beyond code review

• UXWS/stakeholder approval has been confirmed.
• UXWS/stakeholder review will be completed retroactively.
• UXWS/stakeholder review is not needed.

Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code

• I have confirmed that the code works as intended.
• Any CodeClimate issues have been fixed or confirmed as
  added technical debt.

Documentation

• The commit message is clear and follows our guidelines
  (not just this pull request message).
• The documentation has been updated or is unnecessary.
• New dependencies are appropriate or there were no changes.

Testing

• There are appropriate tests covering any new functionality.
• No additional test coverage is required.

[qltysh]

❌ 45 blocking issues (52 total)

Tool	Category	Rule	Count
rubocop	Lint	Assignment Branch Condition size for results is too high. [<6, 33, 8> 34.48/17]	10	❌
rubocop	Lint	Method has too many lines. [25/10]	10	❌
rubocop	Lint	Unused block argument - query. If it's necessary, use \_ or \_query as an argument name to indicate that it won't be used.	7	❌
rubocop	Lint	Class has too many lines. [339/100]	4	❌
rubocop	Lint	Unnecessary symbol conversion; use :"\#\{source\}\_exhausted" instead.	3	❌
rubocop	Lint	Cyclomatic complexity for results is too high. [8/7]	2	❌
rubocop	Lint	Parenthesize the param second\[:results\]\.first\(2\)\.map \{ |result| result\[:identifier\] \} to make sure that the block will be associated with the second\[:results\]\.first\(2\)\.map method call.	2	❌
rubocop	Lint	Perceived complexity for fetch\_primo\_data is too high. [13/8]	1	❌
rubocop	Style	Incorrect formatting, autoformat by running qlty fmt.	1	❌
rubocop	Style	Favor a normal if-statement over a modifier clause in a multiline statement.	1	❌
rubocop	Style	Align the keys of a hash literal if they span more than one line.	1	❌
rubocop	Lint	Avoid parameter lists longer than 5 parameters. [6/5]	1	❌
rubocop	Lint	Duplicate branch body detected.	1	❌
rubocop	Lint	Rename has\_more? to more?.	1	❌
qlty	Structure	Function with many parameters (count = 4): ensure_ordered_results	4
qlty	Structure	Function with high complexity (count = 6): ensure_ordered_results	2
qlty	Structure	Function with many returns (count = 4): exhaustion_reason	1

@qltysh one-click actions:

• Auto-fix formatting (qlty fmt && git push)

[coveralls]

Coverage Report for CI Build 29344103518

Coverage decreased (-0.1%) to 98.273%

Details

• Coverage decreased (-0.1%) from the base build.
• Patch coverage: 2 uncovered changes across 2 files (138 of 140 lines covered, 98.57%).
• No coverage regressions found.

Uncovered Changes

File	Changed	Covered	%
app/models/merged_search_service.rb	109	108	99.08%
app/models/normalize_primo_record.rb	3	2	66.67%
Total (4 files)	140	138	98.57%

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	1563
Covered Lines:	1536
Line Coverage:	98.27%
Coverage Strength:	74.93 hits per line

---

💛 - Coveralls