Remote redundant part for noahmp soil init#1311
Remote redundant part for noahmp soil init#1311CharlesZheZhang wants to merge 1 commit intoMPAS-Dev:hotfix-v8.2.3from
Conversation
|
@CharlesZheZhang Based on a global 120-km test, the changes in this PR appear to have no impact on results -- which I think we should expect if the removed code is truly redundant -- and I can see where the redundant code in Could you amend the message in commit adfcc4a with a more detailed explanation of the changes in the commit? Ideally, the commit message would stand on its own and not reference another PR or commit. Regarding commit message format, we typically use the following: A one-line summary (80 chars max) followed by a blank line, then one or more paragraphs (wrapped at 80 chars) explaining the changes in the commit. We preserve commit history when merging PRs in MPAS-Model, and it's possible that others might cherry-pick commits into their own feature branches, and so it's helpful to include details in each commit (especially for anyone reading through commit history in future trying to track down a bug). |
Remove redundant soil liquid water init from NoahMP, based on this previous PR:
#1244
With this previous PR: #1244,
the mpas_noahmp%sh2o field is correctly initialized in calling NoahmpInitMain and correctly assigned to sh2o.
This PR will remove the redundant part (L398-433).
@cenlinhe @barlage