Skip to content

fix(#315): inject AnalyticsManager into full-player sheets (Mac crash) #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cassio-rossi merged 1 commit into from
Jul 21, 2026
Merged

fix(#315): inject AnalyticsManager into full-player sheets (Mac crash) #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...agazine/Features/PodcastLibrary/Sources/Podcast/Modifiers/PodcastMiniPlayerModifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import AnalyticsLibrary
import FeedLibrary
import MacMagazineLibrary
import SwiftUI
Expand All @@ -13,6 +14,7 @@ private struct PodcastMiniPlayerModifier: ViewModifier {
@Environment(PodcastPlayerManager.self) private var manager
@Environment(\.shouldUseSidebar) private var shouldUseSidebar
@Environment(\.colorScheme) private var colorScheme
@EnvironmentObject private var analytics: AnalyticsManager
@Namespace private var animation

public init() {}
Expand All @@ -32,7 +34,7 @@ private struct PodcastMiniPlayerModifier: ViewModifier {
.padding(.horizontal, 20)
.glassEffect(.regular)
}
.fullPlayerSheet(manager: manager)
.fullPlayerSheet(manager: manager, analytics: analytics)
} else {
content
.tabBarMinimizeBehavior(.onScrollDown)
Expand All @@ -45,17 +47,17 @@ private struct PodcastMiniPlayerModifier: ViewModifier {
.matchedTransitionSource(id: "MINIPLAYER", in: animation)
.padding(.horizontal, 8)
}
.fullPlayerSheet(manager: manager)
.fullPlayerSheet(manager: manager, analytics: analytics)
}
} else {
content
.fullPlayerSheet(manager: manager)
.fullPlayerSheet(manager: manager, analytics: analytics)
}
}
}

private extension View {
func fullPlayerSheet(manager: PodcastPlayerManager) -> some View {
func fullPlayerSheet(manager: PodcastPlayerManager, analytics: AnalyticsManager) -> some View {
self.sheet(
isPresented: Binding(
get: { manager.isFullscreen },
Expand All @@ -67,6 +69,7 @@ private extension View {
backgroundGradientStyle: .fourTone
)
.presentationDragIndicator(.visible)
.environmentObject(analytics)
}
}
}
1 change: 1 addition & 0 deletions MacMagazine/Features/PodcastLibrary/Sources/Podcast/Views/Player/FullPlayerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ struct FullPlayerView: View {
isShowingChapterDialog: $isShowingChapterDialog
)
.presentationDragIndicator(.visible)
.environmentObject(analytics)
}
}

Expand Down
Loading