Skip to content

Allow cursors in externally managed transactions #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aryansk wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Draft

Allow cursors in externally managed transactions #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asyncpg/cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def _check_ready(self):
raise exceptions.InterfaceError(
'cursor: the prepared statement is closed')

if not self._connection._top_xact:
if not self._connection.is_in_transaction():
raise exceptions.NoActiveSQLTransactionError(
'cursor cannot be created outside of a transaction')

Expand Down
11 changes: 11 additions & 0 deletions tests/test_cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,17 @@ async def test_cursor_01(self):
'cursor cannot be created.*transaction'):
await st.cursor()

async def test_cursor_external_transaction(self):
await self.con.execute('BEGIN')
try:
st = await self.con.prepare('SELECT generate_series(0, 2)')
cur = await st.cursor()
self.assertEqual(
await cur.fetch(10),
[(0,), (1,), (2,)])
finally:
await self.con.execute('ROLLBACK')

async def test_cursor_02(self):
st = await self.con.prepare('SELECT generate_series(0, 20)')
async with self.con.transaction():
Expand Down