Skip to content

Fix error reporting in create_libaio#5192

Open
andreas-schwab wants to merge 1 commit into
MariaDB:mainfrom
andreas-schwab:main
Open

Fix error reporting in create_libaio#5192
andreas-schwab wants to merge 1 commit into
MariaDB:mainfrom
andreas-schwab:main

Conversation

@andreas-schwab
Copy link
Copy Markdown

The io_setup function in libaio returns a negated errno value on error,
but strerror expects a normal errno value.

The io_setup function in libaio returns a negated errno value on error,
but strerror expects a normal errno value.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies tpool/aio_libaio.cc to pass the negated return value of io_setup to strerror when printing a warning message. Since io_setup returns a negative error code on failure, negating it ensures strerror receives the correct positive error number. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants