Fix error reporting in create_libaio#5192
Conversation
The io_setup function in libaio returns a negated errno value on error, but strerror expects a normal errno value.
|
|
There was a problem hiding this comment.
Code Review
This pull request modifies tpool/aio_libaio.cc to pass the negated return value of io_setup to strerror when printing a warning message. Since io_setup returns a negative error code on failure, negating it ensures strerror receives the correct positive error number. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The io_setup function in libaio returns a negated errno value on error,
but strerror expects a normal errno value.