MDEV-29909 : SST fails when table is defined with DATA DIRECTORY='/pa…#5226
MDEV-29909 : SST fails when table is defined with DATA DIRECTORY='/pa…#5226janlindstrom wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the use of std::filesystem::space with statvfs to determine the available space on the target filesystem. A review comment points out that f_frsize can be 0 on some systems, which would incorrectly result in available space being calculated as 0 and causing the SST to fail; it suggests falling back to f_bsize in such cases.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…th/to' and datafile is larger than datadir space std::filesystem is not available in all supported environments. Replaced by using statvfs if available. If not available return error and SST will fail.
88372d7 to
e113e47
Compare
|
MDEV-29909 is closed which is a bit misleading given the current bug. This should be promoted as a Blocker for the upcoming release i.e. compilation failures means no release packages. |
|
Raised MDEV-40512 and #5450 as quick alternate to this. Its experimental status was around its evolving c++ interface rather than stability. statvfs isn't fully portable. See plugin/disks/information_schema_disks.cc for what a portable implementation would take. I guess that's why they standardised this. |
…th/to' and datafile is larger than datadir space
std::filesystem is not available in all supported environments. Replaced by using statvfs if available. If not available return error and SST will fail.