Disable rpl_parallel_multi_domain_xa - #5452
Open
bnestere wants to merge 1 commit into
Open
Conversation
MDEV-34104 describes why this test fails. It was filed 2 years ago, but the fix is complex, and we keep this failing test around hurting all other devs. The fix is planned, once finished, we can re-enable this test. Signed-off-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Author
|
@knielsen , @andrelkin I really don't like disabling tests, but it feels necessary here. What do you guys think? |
knielsen
approved these changes
Jul 26, 2026
knielsen
left a comment
knielsen
left a comment
Member
There was a problem hiding this comment.
It is ok to disable a test when the reason for the test to fail is fully understood and there is a good reason to do so. It is very important to eliminate sporadic test failures.
You might want to refer to MDEV-34104 also in the disabled.def, as it has a detailed description of the failure (though that can also be found from git blame and the commit message).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDEV-34104 describes why this test fails. It was filed 2 years ago, but the fix is complex, and we keep this failing test around hurting all other development. The fix is planned, once finished, we can re-enable this test.