Added variable to enable simplecov in spec_helper.rb if and only if COVERAGE=true#7960
Open
mrafie1 wants to merge 7 commits into
Open
Added variable to enable simplecov in spec_helper.rb if and only if COVERAGE=true#7960mrafie1 wants to merge 7 commits into
mrafie1 wants to merge 7 commits into
Conversation
Collaborator
Coverage Report for CI Build 26249467980Coverage remained the same at 90.225%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
Contributor
Author
|
PR for wiki changes is up 👍 link |
| BUNDLE_WITHOUT: development:production:console:unicorn | ||
| RAILS_ENV: test | ||
| RSPEC_RENDER_VIEWS: true | ||
| COVERAGE: true |
Collaborator
There was a problem hiding this comment.
Keep these environment variables in alphabetical order
| c.lcov_file_name = 'lcov.info' | ||
| end | ||
| # Enable simplecov only when COVERAGE environment variable is set to true | ||
| simplecov_enable = ENV.fetch('COVERAGE', nil) == 'true' |
Collaborator
There was a problem hiding this comment.
A more conventional variable name is enable_simplecov (or perhaps enable_coverage, since in principle we may switch code coverage libraries in the future)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
.github/workflows/test_ci.ymlCOVERAGEvariable under the jobtest_specenvsectionCOVERAGEset totrueallowing for test coverage to be enabled by default for GitHub CIspec/spec_helper.rbenable_coveragevariableCOVERAGE = TRUEin the.github/workflows/test_ci.ymlfile when GitHub Actions are runningCOVERAGE = TRUEwhen running MarkUs rspec test suitesimplecovgem under if statementsenable_coverageis trueScreenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Documentation Update: Link
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
Currently updating the Wiki to include the new changes. I'll let you know when I'm done with it!