TICKET-535: Add audit logging - #17
Open
Naragod wants to merge 2 commits into
Open
Conversation
donny-wong
reviewed
Jul 10, 2026
donny-wong
left a comment
Contributor
There was a problem hiding this comment.
Excellent work @Naragod. I see this is configured/developed for local testing — anonymous Grafana admin, insecure TLS, Mailpit SMTP, service endpoints on Compose DNS names. How do you plan on configuring for production? Should we have separate settings files for that, or is prod deployment handled elsewhere?
donny-wong
approved these changes
Jul 10, 2026
donny-wong
left a comment
Contributor
There was a problem hiding this comment.
Clarified with @Naragod that we will need to work with sysadmin for production deployment configurations.
david-yz-liu
left a comment
Contributor
There was a problem hiding this comment.
@Naragod this PR incorporates a few different changes that I would like you to pull out into separate PRs, making them easier to review.
- The fix for passing in
system_instructions. - The fix for the API key.
- The change to the
debugmode for running the server. - Changes to the README for using
uvinstead ofpip(which is a good change to make!). - Adding
pytest-covas a dependency.
After those get merged in I'll review the meat of this PR.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three issues with the current implementation:
500errors.Implementation
TRUSTED_PROXY_HOPS) stops callers from faking their address.system_instructionsfield that MarkUs sends and passes it to the AI.Invalid API keyanswer.