chore(app): post-restructure cleanup — dead components + stale doc paths#8630
Open
MarkusNeusinger wants to merge 13 commits into
Open
chore(app): post-restructure cleanup — dead components + stale doc paths#8630MarkusNeusinger wants to merge 13 commits into
MarkusNeusinger wants to merge 13 commits into
Conversation
ScienceNote, PaletteStrip (only consumer: ScienceNote), CodeShowcase, BareLayout, and PlotOfTheDay (superseded by PlotOfTheDayTerminal) had no importers besides their own tests and barrel entries — verified across src including vi.mock specifiers and lazy imports. Removed with their tests and barrel lines; usePlotOfTheDay (the hook) stays, LandingPage uses it. Follow-up to the frontend modernization roadmap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused React components (and their barrel exports/tests) from the app/ frontend as part of the modernization roadmap, reducing dead code in the landing/spec-detail/layout areas.
Changes:
- Removed five unused components:
ScienceNote,PaletteStrip,PlotOfTheDay(superseded),CodeShowcase, andBareLayout. - Removed associated barrel exports from
app/src/sections/**/index.tsandapp/src/layouts/index.ts. - Removed the now-obsolete unit test file for
PlotOfTheDay.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/sections/spec-detail/index.ts | Removes barrel export for deleted CodeShowcase. |
| app/src/sections/spec-detail/CodeShowcase.tsx | Deletes unused spec-detail marketing/showcase component. |
| app/src/sections/landing/ScienceNote.tsx | Deletes unused landing section component. |
| app/src/sections/landing/PlotOfTheDay.tsx | Deletes deprecated landing component (replaced by PlotOfTheDayTerminal). |
| app/src/sections/landing/PlotOfTheDay.test.tsx | Removes tests tied to deleted PlotOfTheDay component. |
| app/src/sections/landing/PaletteStrip.tsx | Deletes unused landing palette strip component. |
| app/src/sections/landing/index.ts | Removes barrel exports for deleted landing components. |
| app/src/layouts/index.ts | Removes barrel export for deleted BareLayout. |
| app/src/layouts/BareLayout.tsx | Deletes unused layout component. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- seo.md: router.tsx → routes/index.tsx - style-guide.md: proseLinkStyle/theme-token sources now theme/tokens.ts + create-theme.ts (re-exported via src/theme); main.tsx no longer hosts theme - design-auditor: glob the new sections/ and layouts/ directories so the audit covers the moved UI code Historical artifacts (agentic/runs, agentic/audits, agentic/specs, agentic/context) intentionally untouched — they are point-in-time records. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MarkusNeusinger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the modernization roadmap: removes five components with no importers (verified across
src/incl.vi.mockspecifiers and lazy route imports — only self-references, own tests, and barrel entries):sections/landing/ScienceNote.tsxsections/landing/PaletteStrip.tsx(its only consumer was ScienceNote)sections/landing/PlotOfTheDay.tsx(superseded byPlotOfTheDayTerminal, which stays — as does theusePlotOfTheDayhook used by LandingPage)sections/spec-detail/CodeShowcase.tsxlayouts/BareLayout.tsxRemoved together with their test files and barrel lines. No orphans left behind: everything these files imported (paths, theme, lib/api, SectionHeader, paletteMatrices.json, …) has other live consumers.
Verification
yarn lint✓ ·yarn fm:check✓ ·yarn type-check✓ ·yarn test599/599 ✓ ·yarn build✓🤖 Generated with Claude Code
Also in this PR
Doc/agent references updated after the restructure:
seo.md(router path),style-guide.md(theme token sources),design-auditor(globs now includesections/andlayouts/). CLAUDE.md, copilot-instructions.md and the other audit skills were checked and need no changes (genericapp/src/**references). Historical artifacts underagentic/runs|audits|specs|contextare intentionally untouched.