fix(DataGrid): add VerticalContentAlignment/HorizontalContentAlignment bindings to DataGridCell ContentPresenter#4069
Open
JyslaFancy wants to merge 1 commit into
Conversation
…t to DataGridCell ContentPresenter The MaterialDesignDataGridCell ControlTemplate's ContentPresenter was missing bindings for VerticalContentAlignment and HorizontalContentAlignment. This meant users could not properly vertically center cell content using the standard VerticalContentAlignment property, leading them to misuse VerticalAlignment instead — which caused the DataGridCell to shrink within its row, exposing DataGrid grid lines as unwanted 'extra border lines' above and below the cell. Fix: Added HorizontalAlignment and VerticalAlignment TemplateBindings to the ContentPresenter, matching the pattern already used in DataGridColumnHeader. Fixes MaterialDesignInXAML#3999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3999 — Vertical Centering of DataGrid Cells producing extra border lines.
Root cause
The ControlTemplate's ContentPresenter was missing bindings for and .
When users wanted to vertically center cell content, they would set on the DataGridCell style. This caused the DataGridCell itself to shrink vertically within its row, exposing DataGrid horizontal grid lines as unwanted border artifacts above and below the cell.
The correct property to use is — but even that had no effect because the ContentPresenter lacked the TemplateBinding.
Fix
Added and to the ContentPresenter, matching the pattern already used in (line 322 of the same file).
Before
After
Usage
Users can now vertically center cell content correctly: