Skip to content

Store raw identifier values without SQL quoting in mz_*_source_tables catalog tables#35513

Merged
bobbyiliev merged 1 commit intoMaterializeInc:mainfrom
bobbyiliev:fix-kafka-topic-quoting-in-catalog
Mar 30, 2026
Merged

Store raw identifier values without SQL quoting in mz_*_source_tables catalog tables#35513
bobbyiliev merged 1 commit intoMaterializeInc:mainfrom
bobbyiliev:fix-kafka-topic-quoting-in-catalog

Conversation

@bobbyiliev
Copy link
Copy Markdown
Contributor

@bobbyiliev bobbyiliev commented Mar 16, 2026

Breaking change. Store raw identifier values in the mz_kafka_source_tables,
mz_mysql_source_tables, and mz_postgres_source_tables system catalog tables
without SQL quoting. For example, a Kafka topic previously stored as "my-kafka-topic"
now appears as my-kafka-topic. This change should have no user impact, but please
let us know if you run into any issues.

Fixes https://github.com/MaterializeInc/database-issues/issues/11202

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@bobbyiliev bobbyiliev force-pushed the fix-kafka-topic-quoting-in-catalog branch from 3fbfdb8 to 0c1ca3a Compare March 16, 2026 20:26
@bobbyiliev bobbyiliev marked this pull request as ready for review March 16, 2026 20:56
@bobbyiliev bobbyiliev requested a review from a team as a code owner March 16, 2026 20:56
@bobbyiliev bobbyiliev requested a review from SangJunBak March 16, 2026 20:56
Copy link
Copy Markdown
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

My only slight concern is that this is, strictly speaking, a breaking change. That is, in theory, somebody might be relying on us automatically quoting these, right? But you know the ecosystem of external tools that might be reading these tables better than me, so if you think the risk is minimal, then feel free to go ahead. Still, we might want to mention this in the release notes, so that if it happens to break someone's workflow, it will be at least easier for them to figure out what's going on.

@bobbyiliev bobbyiliev force-pushed the fix-kafka-topic-quoting-in-catalog branch from 0c1ca3a to 02094fe Compare March 30, 2026 08:45
@bobbyiliev bobbyiliev merged commit 9a22527 into MaterializeInc:main Mar 30, 2026
119 checks passed
def- added a commit to def-/materialize that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants