Store raw identifier values without SQL quoting in mz_*_source_tables catalog tables#35513
Merged
bobbyiliev merged 1 commit intoMaterializeInc:mainfrom Mar 30, 2026
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
3fbfdb8 to
0c1ca3a
Compare
ggevay
approved these changes
Mar 17, 2026
Contributor
ggevay
left a comment
There was a problem hiding this comment.
LGTM
My only slight concern is that this is, strictly speaking, a breaking change. That is, in theory, somebody might be relying on us automatically quoting these, right? But you know the ecosystem of external tools that might be reading these tables better than me, so if you think the risk is minimal, then feel free to go ahead. Still, we might want to mention this in the release notes, so that if it happens to break someone's workflow, it will be at least easier for them to figure out what's going on.
…s` catalog tables
0c1ca3a to
02094fe
Compare
def-
added a commit
to def-/materialize
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change. Store raw identifier values in the
mz_kafka_source_tables,mz_mysql_source_tables, andmz_postgres_source_tablessystem catalog tableswithout SQL quoting. For example, a Kafka topic previously stored as
"my-kafka-topic"now appears as
my-kafka-topic. This change should have no user impact, but pleaselet us know if you run into any issues.
Fixes https://github.com/MaterializeInc/database-issues/issues/11202