Revert #36537 and #36514#36553
Merged
Merged
Conversation
SangJunBak
approved these changes
May 14, 2026
Member
Author
|
Thanks for the review! |
…)" This reverts commit 54d089c.
…s close (MaterializeInc#36537)" This reverts commit ff13539.
antiguru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reverts #36537. Caused regression tracked in SQL-299. Forward fix in #36548 will take more time; reverting in the interim to unblock.
Also reverts #36514 (container builders for the persist source) because it was merged on top of #36537 and propagates the same generalization through
txn-wal::operator::txns_progress/txns_progress_frontiers, so #36537 can't be reverted in isolation. Once #36548 lands, both #36514 and #36537 can be re-applied.Description
Revert "Container builders for the persist source (#36514)"Revert "txn-wal: deasync txns_progress_frontiers + retain remap across close (#36537)"Pure
git revert, no manual edits.Verification
cargo check -p mz-txn-wal -p mz-persist-client -p mz-storageclean.