<feature>[sdk]: add requestCpu and add errCode#3581
<feature>[sdk]: add requestCpu and add errCode#3581zstack-robot-2 wants to merge 1 commit into5.5.12from
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough将 Groovy 测试库中的三个 bare-metal 辅助方法与它们构造的 SDK Action 类的映射进行了互换/重排;在 CloudOperationsErrorCode 中新增了五个公开的错误代码常量( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 彩蛋诗
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.41.1)utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.javaComment |
add requestCpuNum and requestMemorySize; add loudOperationsErrorCode Resolves: ZSTAC-80103 Change-Id: Ib1c2d3e4f5a6b7c8d9e0f1a2b3c4d5e6f7a8b9c0
fe2b5db to
74921d0
Compare
|
Comment from ye.zou: Code Review: ZSTAC-80103 (R2)进度: 5/11 resolved (45%) 完整 review 见: http://dev.zstack.io:9080/zstackio/zstack/-/merge_requests/9309 |
add requestCpuNum and requestMemorySize;
add loudOperationsErrorCode
Resolves: ZSTAC-80103
Change-Id: Ib1c2d3e4f5a6b7c8d9e0f1a2b3c4d5e6f7a8b9c0
sync from gitlab !9440