Skip to content

<fix>[sdk]: add shareType field to GPU query APIs#3614

Open
zstack-robot-1 wants to merge 1 commit into5.5.12from
sync/zhong.xian/fix/ZSTAC-82599@@2
Open

<fix>[sdk]: add shareType field to GPU query APIs#3614
zstack-robot-1 wants to merge 1 commit into5.5.12from
sync/zhong.xian/fix/ZSTAC-82599@@2

Conversation

@zstack-robot-1
Copy link
Copy Markdown
Collaborator

Resolves: ZSTAC-82599

Change-Id: I7576776a706d6571756e727165776163736e676b

sync from gitlab !9475

Resolves: ZSTAC-82599

Change-Id: I7576776a706d6571756e727165776163736e676b
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 3c593c96-03b1-447f-9129-79a3d88d655d

📥 Commits

Reviewing files that changed from the base of the PR and between c4c23a6 and 0399f4b.

⛔ Files ignored due to path filters (4)
  • sdk/src/main/java/org/zstack/sdk/MdevDeviceInventory.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/MdevDeviceSpecInventory.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/PciDeviceInventory.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/PciDeviceSpecInventory.java is excluded by !sdk/**
📒 Files selected for processing (1)
  • testlib/src/main/java/org/zstack/testlib/ApiHelper.groovy

概述

三个 BareMetal2 相关的 ApiHelper DSL 方法(addBareMetal2GatewayaddBareMetal2DpuChassisaddBareMetal2IpmiChassis)在源文件中的位置进行了重新排列,各方法的 @DelegatesTo 注解和对应 SDK 操作类也作相应调整以保持一致。

更改内容

队列 / 文件 总结
BareMetal2 方法重排
testlib/src/main/java/org/zstack/testlib/ApiHelper.groovy
重新排列三个 API 辅助方法的声明顺序:addBareMetal2Gateway 现映射到 AddBareMetal2GatewayActionaddBareMetal2DpuChassis 映射到 AddBareMetal2DpuChassisActionaddBareMetal2IpmiChassis 映射到 AddBareMetal2IpmiChassisAction。轻微空白调整,核心逻辑无变化。

代码审查工作量估计

🎯 2 (简单) | ⏱️ ~10 分钟

诗歌

🐰✨
方法们排好队,各得其所,
Gateway、DpuChassis、IpmiChassis,
顺序调整,对应更清晰,
每个家族都找到了正确位置,
代码整齐,逻辑如初!


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Title check ❌ Error PR标题声称添加GPU查询API的shareType字段,但实际改动仅涉及交换ApiHelper中三个BareMetal2相关方法的顺序和whitespace调整。 更新标题以准确反映实际改动,例如:'[testlib]: Reorder BareMetal2 DSL methods in ApiHelper'
Description check ⚠️ Warning 描述与实际代码改动不相关。PR描述声称添加shareType字段到GPU查询API,但改动实际上是在testlib的ApiHelper.groovy中重新排列BareMetal2相关方法。 更新描述以准确反映ApiHelper中BareMetal2方法的重新排列,包括受影响的具体方法和改动的原因。
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/zhong.xian/fix/ZSTAC-82599@@2

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZStack-Robot
Copy link
Copy Markdown
Collaborator

Comment from ye.zou:

Code Review: ZSTAC-82599 (R1)

进度: 0/10 resolved (0%)

完整 review 见: http://dev.zstack.io:9080/zstackio/premium/-/merge_requests/13343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants