Skip to content

<fix>[compute]: avoid dual MN host tracking#4431

Open
ZStack-Robot wants to merge 1 commit into
5.4.10from
sync/yaohua.wu/bugfix/ZSTAC-86365-5.4.10
Open

<fix>[compute]: avoid dual MN host tracking#4431
ZStack-Robot wants to merge 1 commit into
5.4.10from
sync/yaohua.wu/bugfix/ZSTAC-86365-5.4.10

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

ZSTAC-86365

Summary

Backport the ZSTAC-76341 zstack fix to 5.4.10.

Root Cause

Dual management nodes can both track the same host when ownership is not checked before host tracking.

Fix

Backport source commit bd5119a to check isManagedByUs before trackHost.

Verification

  • Cherry-pick to upstream/5.4.10 completed cleanly.
  • git diff --check upstream/5.4.10..HEAD passed.
  • Full regression was not run locally.

Related: ZSTAC-86365, ZSTAC-76341

sync from gitlab !10393

Backport the host tracking guard to 5.4.10.

1. Why?
ZSTAC-86365 tracks dual management nodes tracking the same host.
The target branch does not contain the source fix yet.

2. How?
Check isManagedByUs before trackHost to avoid duplicate tracking.

3. Side effects?
None. The change only skips host tracking on non-owner MNs.

# Summary of changes (by module):
- compute: guard host tracking by management node ownership.
- test: cover host connected time tracking behavior.

Source-Commit: bd5119a
Related: ZSTAC-86365, ZSTAC-76341
Change-Id: I6de8611b596a775d893d2dde91ac89410f69bf2c
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: aa72ac2f-3b2e-47f1-aadf-4de029b1a87d

📥 Commits

Reviewing files that changed from the base of the PR and between 08177ca and 3afc80d.

📒 Files selected for processing (2)
  • compute/src/main/java/org/zstack/compute/host/HostTrackImpl.java
  • test/src/test/groovy/org/zstack/test/integration/kvm/host/HostConnectedTimeCase.groovy

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/yaohua.wu/bugfix/ZSTAC-86365-5.4.10

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant