<fix>[compute]: avoid dual MN host tracking#4431
Conversation
Backport the host tracking guard to 5.4.10. 1. Why? ZSTAC-86365 tracks dual management nodes tracking the same host. The target branch does not contain the source fix yet. 2. How? Check isManagedByUs before trackHost to avoid duplicate tracking. 3. Side effects? None. The change only skips host tracking on non-owner MNs. # Summary of changes (by module): - compute: guard host tracking by management node ownership. - test: cover host connected time tracking behavior. Source-Commit: bd5119a Related: ZSTAC-86365, ZSTAC-76341 Change-Id: I6de8611b596a775d893d2dde91ac89410f69bf2c
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Warning
|
ZSTAC-86365
Summary
Backport the ZSTAC-76341 zstack fix to 5.4.10.
Root Cause
Dual management nodes can both track the same host when ownership is not checked before host tracking.
Fix
Backport source commit bd5119a to check isManagedByUs before trackHost.
Verification
git diff --check upstream/5.4.10..HEADpassed.Related: ZSTAC-86365, ZSTAC-76341
sync from gitlab !10393