Skip to content

<fix>[guesttools]: support emoji script output#4433

Open
MatheMatrix wants to merge 1 commit into
5.4.10from
sync/yaohua.wu/bugfix/ZSTAC-86425@@2
Open

<fix>[guesttools]: support emoji script output#4433
MatheMatrix wants to merge 1 commit into
5.4.10from
sync/yaohua.wu/bugfix/ZSTAC-86425@@2

Conversation

@MatheMatrix

Copy link
Copy Markdown
Owner

ZSTAC-86425

Summary

Backport the ZSTAC-80478 zstack schema fix to 5.4.10.

Root Cause

Guest script stdout/stderr can contain four-byte UTF-8 characters such as emoji. The existing GuestVmScriptExecutedRecordDetailVO columns cannot store those characters correctly with the old charset.

Fix

Add 5.4.10 schema DDL to modify stdout and stderr to utf8mb4 with utf8mb4_unicode_ci collation.

Upgrade Idempotence

The SQL uses ALTER TABLE MODIFY to set the same final column definitions. Re-running the DDL keeps the columns at the same definition, so the upgrade is idempotent.

Verification

  • SQL was placed in conf/db/upgrade/V5.4.10__schema.sql, not V5.5.6__schema.sql.
  • git diff --check upstream/5.4.10..HEAD passed.
  • Full regression was not run locally.

Related: ZSTAC-86425, ZSTAC-80478

sync from gitlab !10395

Backport script output utf8mb4 storage to 5.4.10.

1. Why?
Guest script stdout and stderr can contain four-byte UTF-8 characters.
The old column charset cannot store emoji output correctly.

2. How?
Change stdout and stderr columns to utf8mb4 in V5.4.10 schema.
The ALTER MODIFY statements are idempotent for repeated upgrades.

3. Side effects?
Column charset changes to utf8mb4 with utf8mb4_unicode_ci collation.

# Summary of changes (by module):
- db: alter guest script stdout and stderr columns to utf8mb4.

Source-Commit: da699ea
Related: ZSTAC-86425, ZSTAC-80478
Change-Id: I9e8458c2c6b497afb3d00545019f1c6419acccf1
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a8f70b7d-5285-4412-828c-e09f05d94340

📥 Commits

Reviewing files that changed from the base of the PR and between 08177ca and f1612f5.

📒 Files selected for processing (1)
  • conf/db/upgrade/V5.4.10__schema.sql

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/yaohua.wu/bugfix/ZSTAC-86425@@2

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant