<fix>[guesttools]: support emoji script output#4433
Conversation
Backport script output utf8mb4 storage to 5.4.10. 1. Why? Guest script stdout and stderr can contain four-byte UTF-8 characters. The old column charset cannot store emoji output correctly. 2. How? Change stdout and stderr columns to utf8mb4 in V5.4.10 schema. The ALTER MODIFY statements are idempotent for repeated upgrades. 3. Side effects? Column charset changes to utf8mb4 with utf8mb4_unicode_ci collation. # Summary of changes (by module): - db: alter guest script stdout and stderr columns to utf8mb4. Source-Commit: da699ea Related: ZSTAC-86425, ZSTAC-80478 Change-Id: I9e8458c2c6b497afb3d00545019f1c6419acccf1
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Warning
|
ZSTAC-86425
Summary
Backport the ZSTAC-80478 zstack schema fix to 5.4.10.
Root Cause
Guest script stdout/stderr can contain four-byte UTF-8 characters such as emoji. The existing GuestVmScriptExecutedRecordDetailVO columns cannot store those characters correctly with the old charset.
Fix
Add 5.4.10 schema DDL to modify stdout and stderr to utf8mb4 with utf8mb4_unicode_ci collation.
Upgrade Idempotence
The SQL uses ALTER TABLE MODIFY to set the same final column definitions. Re-running the DDL keeps the columns at the same definition, so the upgrade is idempotent.
Verification
git diff --check upstream/5.4.10..HEADpassed.Related: ZSTAC-86425, ZSTAC-80478
sync from gitlab !10395