<fix>[zwatch]: migrate VRouter CPU alarm metric#4434
Conversation
Backport the VPC router CPU alarm metric migration to 5.4.10. 1. Why? The one-click VPC router CPU alarm should use external monitoring data. Existing templates and alarms still point to the average VRouter metric. 2. How? Add an idempotent 5.4.10 schema update to move the active template and related alarms to CPUUsedUtilization. 3. Side effects? None. The UPDATE statements only match rows with the old metric name. # Summary of changes (by module): - db upgrade: migrate VPC router active alarm metric names. Related: ZSTAC-86505 Change-Id: I6d085c36d6a46f408c8905302cf36f83aea4c2cc
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Warning
|
ZSTAC-86505
Root Cause
The one-click VPC router CPU alarm should evaluate against external monitoring data. Existing active alarm templates and alarms still reference
VRouterCPUAverageUsedUtilization, so recovery/current values can mismatch the intended trigger metric.Fix
Add a 5.4.10 schema migration that moves the VPC router CPU active alarm template and existing linked alarms to
CPUUsedUtilization.Upgrade Idempotence
Both UPDATE statements are guarded by the old metric name. After the first run, rows no longer match
VRouterCPUAverageUsedUtilization, so re-running the upgrade has no additional effect.Test
conf/db/upgrade/V5.4.10__schema.sql.git diff --check upstream/5.4.10..HEADpassed.Related MRs
Related: ZSTAC-86505, ZSTAC-79949
sync from gitlab !10396