<feature>[ai]: refresh SDK for vLLM template upgrade#4436
Open
MatheMatrix wants to merge 1 commit into
Open
Conversation
Regenerate Java SDK outputs for AI model cache APIs. This makes update_sdk produce no diff on feature-5.5.28-aios. Resolves: ZSTAC-86068 Change-Id: I8606800000000000000000000000000000000003
|
Warning
|
| Layer / File(s) | Summary |
|---|---|
移除inventories字段泛型约束 sdk/src/main/java/org/zstack/sdk/GetAiHostModelCacheCapacityResult.java, sdk/src/main/java/org/zstack/sdk/QueryAiHostModelCacheResult.java, sdk/src/main/java/org/zstack/sdk/RefreshAiHostModelCacheResult.java |
三个类的inventories字段及其setter/getter方法的类型从List<AiHostCacheStorageInventory>或List<AiHostModelCacheInventory>统一改为原生java.util.List。 |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Poem
泛型退场，原生登台，
三份结果，同心裁剪，
兔耳竖起，代码轻快，
编译警告，静待除害，
一跳一跃，PR新载！🐇✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | 标题简洁且与本次刷新 AI 模型缓存相关 SDK 代码生成的变更一致。 |
| Description check | ✅ Passed | 描述明确说明了刷新 AI 模型缓存 API 的 Java SDK，并补充了关联 MR 和验证信息。 |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
sync/xinhao.huang/feat/vllm-0.24.0-aios-premium
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@sdk/src/main/java/org/zstack/sdk/GetAiHostModelCacheCapacityResult.java`:
- Around line 6-10: The GetAiHostModelCacheCapacityResult inventories field is
using a raw List, which drops type safety and IDE support. Update the
inventories member along with setInventories and getInventories to use
List<AiHostCacheStorageInventory> instead of the raw List so the result model
preserves its generic type information.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 534883d4-839b-4639-8e37-ef5babe20b96
📒 Files selected for processing (3)
sdk/src/main/java/org/zstack/sdk/GetAiHostModelCacheCapacityResult.javasdk/src/main/java/org/zstack/sdk/QueryAiHostModelCacheResult.javasdk/src/main/java/org/zstack/sdk/RefreshAiHostModelCacheResult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check HEAD~1..HEADrunMavenProfile sdkoutput from the full premium buildJira: http://jira.zstack.io/browse/ZSTAC-86068
sync from gitlab !10391