Skip to content

<fix>[kvm]: ZSTAC-85800 sync command timeout#4444

Closed
ZStack-Robot wants to merge 1 commit into
5.5.28from
sync/haidong.pang/fix/ZSTAC-85800-volume-cache-rollback-cleanup@@2
Closed

<fix>[kvm]: ZSTAC-85800 sync command timeout#4444
ZStack-Robot wants to merge 1 commit into
5.5.28from
sync/haidong.pang/fix/ZSTAC-85800-volume-cache-rollback-cleanup@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Summary

  • Sync explicitly configured KVMHostHttpCallMsg timeout into HasThreadContext command task context before command JSON serialization.
  • Keeps rollback cleanup callers from leaking stale API deadlines into kvmagent task daemons.

Dependency

  • Pair with premium MR from the same source branch: fix/ZSTAC-85800-volume-cache-rollback-cleanup@@2.

Testing

  • rtk git -C zstack diff --check upstream/5.5.28..HEAD
  • VolumeCacheCase not completed: initial MR-ref run failed because the wrongly-created MR exposed no refs/merge-requests/*/head; branch-based container verification reached the standard test-premium --package precompile path, but was stopped after the heavy dependency build stalled before the case started.

Resolves: ZSTAC-85800

sync from gitlab !10406

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 91d39773-b007-4731-9735-287a4054785d

📥 Commits

Reviewing files that changed from the base of the PR and between b31fe63 and 725854a.

📒 Files selected for processing (1)
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMHostHttpCallMsg.java

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/haidong.pang/fix/ZSTAC-85800-volume-cache-rollback-cleanup@@2

Comment @coderabbitai help to get the list of available commands.

Sync an explicitly configured KVM message timeout into HasThreadContext command task context before serializing the command, so agent-side task timeout receives the same fresh deadline.

Resolves: ZSTAC-85800

Change-Id: Ia6df378166f2e0600dfa2b1985b2ce722187fac0
@MatheMatrix MatheMatrix force-pushed the sync/haidong.pang/fix/ZSTAC-85800-volume-cache-rollback-cleanup@@2 branch from beeaeb7 to 725854a Compare July 3, 2026 09:36
@zstack-robot-2 zstack-robot-2 deleted the sync/haidong.pang/fix/ZSTAC-85800-volume-cache-rollback-cleanup@@2 branch July 6, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant