Store cached git repos by URL, not submodule directory name#18
Open
abranson wants to merge 1 commit into
Open
Conversation
may clash with other repos (e.g. 'upstream'). Instead just use the remaining last path component of the URL.
larstiq
approved these changes
Sep 15, 2016
Contributor
larstiq
left a comment
larstiq
left a comment
There was a problem hiding this comment.
With this change it's possible submodules will be cached in a different directory. Initial clone will then be a bit slower, and total disk usage higher until the cache is cleared out.
Will keep this in mind when deploying.
| URL=$MYURL | ||
| cache_prefetch $CLONE_NAME $URL | ||
| cache_prefetch $URL | ||
| MYURL=$URL |
Contributor
There was a problem hiding this comment.
I was afraid for CLONE_NAME we'd lose the logic of parse_url, but basename nicely does the same thing \o/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove name parameter from cache_prefetch, as the local directory name
may clash with other repos (e.g. 'upstream'). Instead just use the
remaining last path component of the URL.