feat: polish the Other tab and display-trigger list#62
Merged
Conversation
The display-trigger list arrived with the tab's only section header, leaving the two handoff toggles as unlabeled one-row islands and the license/version rows trailing unlabeled. Label the groups — General, Peripheral handling (both handoff toggles together), the display list, About (license + version + updates merged) — so the tab reads as four topics instead of six fragments.
- A refresh button in the section header (the Device tab's arrow.clockwise idiom) re-reads the online displays immediately, bypassing the reconcile debounce; opening the tab does the same silently, so the list is current the moment the user looks. - A remembered-but-disconnected display now shows a trash button (the Device tab's row idiom) instead of a toggle. Unmarking is forgetting — the trigger map is the only memory — so the old toggle was a remove control in disguise; the trash button says what it does. Connected rows keep their toggle.
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up UI polish for #61 (#59), from looking at the tab as merged.
Labeled sections
The display-trigger list arrived with the tab's only section header, leaving the two handoff toggles as unlabeled one-row islands and license/version trailing unlabeled. The tab now reads as four topics: General (Launch at Login), Peripheral handling (both handoff toggles together), Take peripherals when a display connects, and About (license + version + updates merged).
Refresh
The display section header gains the Device tab's
arrow.clockwiserefresh button — it re-reads the online displays immediately, bypassing the 2s reconcile debounce. Opening the tab does the same silently, so the list is current the moment you look. It runs the normal reconcile, so a genuinely pending dock edge fires then rather than being lost.Forget
A remembered-but-disconnected display now shows the Device tab's red trash button instead of a toggle. Unmarking is forgetting — the trigger map is the only memory — so the old toggle was a remove control in disguise; the trash button says what it does (tooltip: "Forget name — it will no longer trigger a switch when it connects."). Connected rows keep their toggle, whose off state remains a plain unmark.
Built clean with the CI toolchain;
swift formatno-op.