Skip to content

Check-in - Add 'bisection' argument to 'prepare_ae_forestly' per Issu…#122

Open
lm3388 wants to merge 3 commits intomainfrom
Issue120_add_bisection_argument_for_prepare_ae_forestly
Open

Check-in - Add 'bisection' argument to 'prepare_ae_forestly' per Issu…#122
lm3388 wants to merge 3 commits intomainfrom
Issue120_add_bisection_argument_for_prepare_ae_forestly

Conversation

@lm3388
Copy link
Copy Markdown
Collaborator

@lm3388 lm3388 commented Mar 20, 2026

The bisection argument added to prepare_ae_forestly function definition that is passed down to metalite.ae::extend_ae_specific_inference and then to metalite.ae::rate_compare_sum.

@lm3388 lm3388 requested a review from wangben718 March 20, 2026 18:52
@wangben718
Copy link
Copy Markdown
Collaborator

Hi @lm3388. Could you run devtools::document() to add the documentation for the new added argument? Everything else looks well.

@lm3388
Copy link
Copy Markdown
Collaborator Author

lm3388 commented Mar 25, 2026

Have run devtools::document() and the updated prepare_ae_forestly.rd file checked-in for review

@wangben718
Copy link
Copy Markdown
Collaborator

Have run devtools::document() and the updated prepare_ae_forestly.rd file checked-in for review

Hi @lm3388 , could you write some description for the new argument bisection and ...? You can refer to

#' @param ... Additional arguments passed to [reactable::reactable()].
. After that, please run devtools::document() and check in again.

@lm3388
Copy link
Copy Markdown
Collaborator Author

lm3388 commented Mar 26, 2026

The 'bisection' has been addressed in param area in prepare_ae_forestly function, with devtools::document() run afterward. Thanks to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants