Expand ESNZ Rose Stem Tests#477
Conversation
0c28718 to
aa76227
Compare
|
This PR should be good to go - Matthew Hambley (@MatthewHambley), Joerg Henrichs (@hiker), and thomasmelvin are you happy with the changes? Who should I ask for SR? Thanks! |
Matthew Hambley (MatthewHambley)
left a comment
There was a problem hiding this comment.
Code Owner Review: This looks fine. My only question is - is there a risk that always appending to the file could lead to a file which grows forever until it fills the disc?
|
Thanks for the review Matthew Hambley (@MatthewHambley). With regards to |
|
Joerg Henrichs (@hiker) are you happy with the changes in this ticket? |
Joerg Henrichs (hiker)
left a comment
There was a problem hiding this comment.
All good from my point of view.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Sam Clarke-Green (@t00sa)
This PR expands ESNZ Rose Stem testing for LFRic Apps to cover additional test cases and miniapps, closing #468. It also updates the ESNZ site configuration, LFRic build system, and Rose Stem apps to enable these tests:
Changes in common directories:
ifx.mkinclude file adds support for the Intel OneAPI Fortran compiler tongarchminiapp buildsncap2utility on ESNZ's Cascade HPC requires setting flag-Afor appending files explicitly; this should not affect other sites where this flag seems to be optional.This PR depends on MetOffice/lfric_core#359.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric_apps_468_expand_esnz_testing/run1
Suite Information
Task Information
✅ succeeded tasks - 243
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review