Skip to content

Fix PR#377 Enable Transmute script for bl imp and exp kernels - over i#534

Open
Benjamin Went (MetBenjaminWent) wants to merge 4 commits into
MetOffice:mainfrom
MetBenjaminWent:transmute_bl_exp_imp_kernels_2
Open

Fix PR#377 Enable Transmute script for bl imp and exp kernels - over i#534
Benjamin Went (MetBenjaminWent) wants to merge 4 commits into
MetOffice:mainfrom
MetBenjaminWent:transmute_bl_exp_imp_kernels_2

Conversation

@MetBenjaminWent
Copy link
Copy Markdown
Contributor

@MetBenjaminWent Benjamin Went (MetBenjaminWent) commented Jun 2, 2026

Create or enable a Transformation script for the boundary layer kernels which affect the domain to add OMP directives.
Introduced is a local.py script for kernels, which if the loop variable is an i or an l, then the OMP directive is added, instead of the top loop like the Transmute global script.
interfaces/physics_schemes_interface/source/kernel/bl_exp_kernel_mod.F90 - Local kernel script with Override
interfaces/physics_schemes_interface/source/kernel/bl_imp_kernel_mod.F90 - Local kernel script with Override
interfaces/physics_schemes_interface/source/kernel/bl_imp2_kernel_mod.F90 - Local kernel script with Override

Performance of all kernels improves as a result of the original changes in PR #377 , see #106. Combined with #416, the implicit umbrella of imp_kernel and imp2_kernel is much greater.

NOTE, these changes have not been explicitly tested, and may be marginally different than #377, though the same loops are still parallelised, but over a different index.

Sci/Tech Reviewer: Hacka Fett (@christophermaynard)
Code Reviewer: svadams (@svadams)

Umbrella Issue: #106
Issue: #361

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - transmute_bl_exp_imp_kernels_2/run7

Suite Information

Item Value
Suite Name transmute_bl_exp_imp_kernels_2/run7
Suite User benjamin.went
Workflow Start 2026-06-02T15:25:59
Groups Run all
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules MetOffice/jules@3647a42 True
lfric_apps MetBenjaminWent/lfric_apps@transmute_bl_exp_imp_kernels_2 False
lfric_core MetOffice/lfric_core@bf23673 True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@3e2998b True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@1cdb9c2 True

Task Information

❌ failed tasks - 2
Task State
run_lfric_atm_scm_gal9_gabls4-BiP2x2-50000x50000_ex1a_cce_fast-debug-32bit failed
run_linear_integration_tests_azspice_gnu_64bit failed
✅ succeeded tasks - 1570

Test Suite Results - lfric_apps - transmute_bl_exp_imp_kernels_2/run6

Suite Information

Item Value
Suite Name transmute_bl_exp_imp_kernels_2/run6
Suite User benjamin.went
Workflow Start 2026-06-02T14:31:40
Groups Run ex1a_omp_developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules MetOffice/jules@3647a42 True
lfric_apps MetBenjaminWent/lfric_apps@transmute_bl_exp_imp_kernels_2 False
lfric_core MetOffice/lfric_core@bf23673 True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@3e2998b True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@1cdb9c2 True

Task Information

✅ succeeded tasks - 51

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@MetBenjaminWent
Copy link
Copy Markdown
Contributor Author

Benjamin Went (MetBenjaminWent) commented Jun 2, 2026

As this is a continuation of PR #377 and issue #361, the performance data and existing approvals should still hold for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants