Fix PR#377 Enable Transmute script for bl imp and exp kernels - over i#534
Open
Benjamin Went (MetBenjaminWent) wants to merge 4 commits into
Open
Conversation
28 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create or enable a Transformation script for the boundary layer kernels which affect the domain to add OMP directives.
Introduced is a
local.pyscript for kernels, which if the loop variable is anior anl, then the OMP directive is added, instead of the top loop like the Transmute global script.interfaces/physics_schemes_interface/source/kernel/bl_exp_kernel_mod.F90- Local kernel script with Overrideinterfaces/physics_schemes_interface/source/kernel/bl_imp_kernel_mod.F90- Local kernel script with Overrideinterfaces/physics_schemes_interface/source/kernel/bl_imp2_kernel_mod.F90- Local kernel script with OverridePerformance of all kernels improves as a result of the original changes in PR #377 , see #106. Combined with #416, the implicit umbrella of imp_kernel and imp2_kernel is much greater.
NOTE, these changes have not been explicitly tested, and may be marginally different than #377, though the same loops are still parallelised, but over a different index.
Sci/Tech Reviewer: Hacka Fett (@christophermaynard)
Code Reviewer: svadams (@svadams)
Umbrella Issue: #106
Issue: #361
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - transmute_bl_exp_imp_kernels_2/run7
Suite Information
Task Information
❌ failed tasks - 2
Test Suite Results - lfric_apps - transmute_bl_exp_imp_kernels_2/run6
Suite Information
Task Information
✅ succeeded tasks - 51
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review