Hygroscopicity MS11 ratio option#31
Conversation
…ults to all sulphate
…stributed between species
…riables that now use mdcopy aren't included in solinsol and the ratio
|
mo-dangrosvenor Hi Dan, I have made the updated changes to all 3 pull requests, adding additional information to the meta data and generally tidying up the changes. Let me know what you think of the latest set up. I have also rerun all the required tests and everything looks okay still. |
|
Hi mo-dangrosvenor, The figures above are the end result values for AOD from running sol/insol rose-stem tests. I am happy to run these tests again with the new set up and the different configurations of values that you have suggested but running a nudged suite will take too long, with the review deadline fast approaching. |
Ok, thanks. It would be necessary to repeat with with the updated code (or are you saying that these were done after the mdcopy bug was fixed?). Some detail on how long the runs ran for (which rose-stem tests?), whether the fields shown are snapshots or time-averages (and over how long if so) etc. would be good. |
|
Hi Dan, I can provide all that information with the figures later today! |
|
Hi mo-dangrosvenor, I have added in a fix to the component issue. All the IF statements were failing for the other species, so like mdcopy, I have created a component_copy which I then set as TRUE for all the soluble imodes for organic carbon and seasalt. This gives a much more realistic answer for when everything is seasalt, that is different to when everything is sulphate. I am now going to rerun all the tests, update the PR main bits and supply soluble accumulation AOD for the different test ratios so that hopefully we can get this through SciTech review soon. Let me know if there is anything you feel I need to change with the latest code I have committed. Joe |
Thanks. It seems like it could've been achieved in a simpler way than creating all those allocatable arrays, though? E.g., by just adding .OR.glomap_config%i_mode_setup == 11 to the IF statements for the relevant components (since you know which ones they are)? I'm also a bit concerned that the code for the nitrate scheme and cp_so are just confusing at this stage since they are not used. I think that they can just be added in future trunk updates when needed? |
That is a much better way of doing it. I will alter the code now and verify it still works. I can also remove it from the nitrate/cp_so. We were thinking it would make it simpler if changes were made in the future but I agree that it can just be done in future updates if required. Will make these changes and then perform all the tests and let you know when it is all good to be checked again. |
|
The figures in the previous comment are much more consistent with what we would expect to see. Comparing all the different set ups we see the same spatial structure for all with different values on the colour bar. All sulphate sees particularly high maximum values with different configurations bringing the values down. Sea salt is very hygroscopic too so sees the 2nd largest values when all the wet part is treated as it. Organic carbon sees much lower values but not as low as black carbon, which as noted before, is not included in the wet growth in UKCA_VOLUME_MODE.F90. |
|
Pierre Siddall (@Pierre-siddall) - I've completed the Sci-Tech review now and am happy with the changes. |
mo-dangrosvenor
left a comment
There was a problem hiding this comment.
I'm happy with the testing, code and documentation now.
Pierre Siddall (Pierre-siddall)
left a comment
There was a problem hiding this comment.
Thanks Joe Carton-Kelly (@JoeCartonKelly-MO), this part of the linked ticket looks goods to me, moving onto the um and um_docs changes now.
|
Hi Joe Carton-Kelly (@JoeCartonKelly-MO) , I'm happy to merge this PR and it's linked tickets to trunk now via a bypass. However, could you set up verified commit for future PRs to ensure that commits don't clash with the branch protection rules being enforced. |
1981f7d
into
MetOffice:main

















PR Summary
Sci/Tech Reviewer: mo-dangrosvenor
This change impacts Glomap mode setup 11 (SOL/INSOL). In this PR we make it so that users can, via a rose namelist (there is an attached UM PR below), redistribute the sulphate aerosol into its 4 actual species (sulphate, sea salt, black carbon and organic carbon) within the hygroscopicity calculations. We found that when treating everything as sulphate, in environments when sulphate is not the dominant aerosol, we saw too much hygroscopic growth from our aerosols and by having this option we allow users to get a better reflection of the growth of the area they are modelling. This change only impacts the wet component of aerosol as we still want the dry element to always be treated as sulphate. This change does not impact the activation scheme outside of the fact that the aerosols are different as a result of their wet part changing. I am going to attach some figures showing the impact that this change can have on aerosol optical depth further downCode Reviewer: Pierre Siddall (@Pierre-siddall)
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
- I have tested this change locally, using the UKCA rose-stem suite
- If shared files have been modified, I have run the UM and LFRic Apps rose
- If any tests fail (rose-stem or CI) the reason is understood and
- I have added tests to cover new functionality as appropriate (eg. system
I have run Mohit's um14.1 rigorous test (a copy of suite dx-502) with the trac.log printed below. I have run umdp3_checker on UKCA and ran the fixer to make it all okay. I will show a full UM solinsol rose-stem-test where I have changed the value to show that kgo fails in this case and one where I haven't to show that it doesn't when given default values.stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
|| Suite Name: || '''u-dy599/run9''' ||
|| Suite Owner: || joseph.cartonkelly ||
|| Report Generated: || 2026/05/12 21:13:28 ||
|| Cylc-Review: || https://cylchub/services/cylc-review/taskjobs/joseph.cartonkelly/?suite=u-dy599/run9 ||
|| ''ROSE_ORIG_HOST:'' || cazldf00000G.spice.sc.metoffice.gov.uk ||
|| '''Task''' || '''State''' ||
|| atmos_cristrat_16x8 || succeeded ||
|| atmos_cristrat_16x8_2omp || succeeded ||
|| atmos_cristrat_col_16x8 || succeeded ||
|| atmos_cristrat_col_8x12 || succeeded ||
|| atmos_cristrat_crun || succeeded ||
|| atmos_cristrat_nrun || succeeded ||
|| atmos_cristrat_rigorous_16x8 || succeeded ||
|| atmos_offl_16x8 || succeeded ||
|| atmos_offl_8x12 || succeeded ||
|| atmos_strat_16x8 || succeeded ||
|| atmos_strat_16x8_2omp || succeeded ||
|| atmos_strat_col_16x8 || succeeded ||
|| atmos_strat_col_8x12 || succeeded ||
|| atmos_strat_crun || succeeded ||
|| atmos_strat_nrun || succeeded ||
|| atmos_strat_rigorous_16x8 || succeeded ||
|| extract || succeeded ||
|| fcm_make || succeeded ||
|| fcm_make_rigorous || succeeded ||
|| housekeep_cririgor || succeeded ||
|| housekeep_cristrat || succeeded ||
|| housekeep_offl || succeeded ||
|| housekeep_rigor || succeeded ||
|| housekeep_strat || succeeded ||
|| recon_cristrat || succeeded ||
|| recon_cristrat_rigorous || succeeded ||
|| recon_offl || succeeded ||
|| recon_strat || succeeded ||
|| recon_strat_rigorous || succeeded ||
|| rose_ana_cristrat_atmos_kgo || succeeded ||
|| rose_ana_cristrat_atmos_nruncrun || succeeded ||
|| rose_ana_cristrat_atmos_omp || succeeded ||
|| rose_ana_cristrat_col_atmos_proc || succeeded ||
|| rose_ana_offl_atmos_kgo || succeeded ||
|| rose_ana_offl_atmos_proc || succeeded ||
|| rose_ana_strat_atmos_kgo || succeeded ||
|| rose_ana_strat_atmos_nruncrun || succeeded ||
|| rose_ana_strat_atmos_omp || succeeded ||
|| rose_ana_strat_atmos_rigorous || succeeded ||
|| rose_ana_strat_col_atmos_kgo || succeeded ||
|| rose_ana_strat_col_atmos_proc || succeeded ||
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review