feat: Add support to native Gatekeeper configurations from app values.yaml#857
Open
afonsobspinto wants to merge 4 commits into
Open
feat: Add support to native Gatekeeper configurations from app values.yaml#857afonsobspinto wants to merge 4 commits into
afonsobspinto wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done as part of https://metacell.atlassian.net/browse/NGLASS-2145 to allow private s3 datasources on iframes
Implemented solution
CloudHarness applications can now supply arbitrary native Gatekeeper proxy.yml settings through their application values:
The configuration uses the native kebab-case property names documented by Gatekeeper, avoiding the need to extend CloudHarness whenever another Gatekeeper option is required.
The effective configuration is built with the following precedence:
Application configuration is therefore the last writer and can override generated or global settings.
The implementation:
This is additive. Existing image, replicas, resources, secret, proxy timeout, and URI-role configuration remain supported.
Individual native Gatekeeper property names and values are not duplicated or validated by CloudHarness.
Gatekeeper remains responsible for validating its native configuration when loading proxy.yml.
Changing the checksum calculation may cause a one-time rolling restart of secured application Gatekeeper pods during the first deployment.
How to test this PR
How to test this PR
Run the model and deployment rendering tests:
The suite verifies:
Sanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):